Skip to content

feat(log): make timing messages ready for HTML replay #16382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
epage merged 5 commits into from
Dec 11, 2025
Merged

feat(log): make timing messages ready for HTML replay #16382

epage merged 5 commits into from
Dec 11, 2025
+171 −75

Conversation

@weihanglo
Copy link
Member

@weihanglo weihanglo commented Dec 11, 2025

What does this PR try to resolve?

Split out from #16377.

Two non-refactor changes are

  • CompileMode now implements Deserialize in a way that matches its Serialize impl.
  • RunId is now 20060724T012128000Z-<16-char-hex>. Previously it was 2006-07-24T012128000Z-<16-char-hex>

How to test and review this PR?

@weihanglo
feat(log): impl serde::Deserialize
c0c9e57 
`CompileMode` didn't implement Deserialize before,
though this implementation is 1:1 mapping to Serialize
so should be okay.
@weihanglo
refactor(timing): avoid UnitTime as argument
84fb58a 
So that this can be reused during timing replay
@weihanglo
refactor(timing): pub and owning more types and fields
e187686 
This is a preparation for HTML replay from `cargo report timings`.
@weihanglo
refactor(log): generate RunId with time parsing
3600c73
@weihanglo
fix(log): make RunId format simpler
b8f996a
@rustbot rustbot added A-build-execution Area: anything dealing with executing the compiler A-timings Area: timings S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 11, 2025
@rustbot
Copy link
Collaborator

rustbot commented Dec 11, 2025

r? @ehuss

rustbot has assigned @ehuss.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@weihanglo weihanglo changed the title feat(log): make timing messages more self-contained feat(log): make timing messages ready for HTML replay Dec 11, 2025
@epage epage enabled auto-merge December 11, 2025 21:03
@epage epage added this pull request to the merge queue Dec 11, 2025
Merged via the queue into rust-lang:master with commit e6b0a65 Dec 11, 2025
28 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 11, 2025
This was referenced Dec 12, 2025
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@epage epage epage approved these changes

Assignees

@ehuss ehuss

Labels

A-build-execution Area: anything dealing with executing the compiler A-timings Area: timings

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@weihanglo @rustbot @epage @ehuss