Skip to content

Fix UB in pool module when using ArcBlock<T> and BoxBlock<T> #612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix UB in pool module when using ArcBlock<T> and BoxBlock<T> #612

wants to merge 3 commits into from

Conversation

Mortano
Copy link
Contributor

@Mortano Mortano commented Sep 19, 2025

This fixes UB when using the ArcBlock<T> and BoxBlock<T> types together with the Stack type, as it occurs in the ArcPoolImpl and BoxPoolImpl types. The underlying cause for the UB was a wrongly initialized UnionNode, as was discussed in #605 . This also required that the functions of the Node trait are unsafe, but this should not be a breaking API change as that trait is never exported from the pool module

sgued
sgued approved these changes Sep 22, 2025
View reviewed changes
Copy link
Contributor

@sgued sgued left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks a lot for the audit of the unsafe code. Already yielding results!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgued sgued sgued approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Mortano @sgued @pc-for-science