Remove implementing Deref<Target = [T]> for HistoryBuf #610
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sirhcel
force-pushed
the
historybuf-no-deref
branch
from
6a380a4 to
19a455f
Compare
There is already `as_slice()` which gives access to the underlying backing array where the elements are not in the order of writing. With automatic dereferencing, functions like `iter()` or `windows()` are automatically available for `HistoryBuf` and are returning items in an order which does not reflect the write order and will likely surprise users which did not carefully read all the documentation on for `HistoryBuf` like me.
sirhcel
force-pushed
the
historybuf-no-deref
branch
from
19a455f to
ccf2896
Compare
|
There is more potential for streamlining the interface of |
|
Probably worth noting this is a breaking change, as removal of the |
|
LGTM. This is a breaking change that should be included in the next breaking change release. Added as sub-issue: #613 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is already
as_slice()which gives access to the underlying backing array where the elements are not in the order of writing.With automatic dereferencing, functions like
iter()orwindows()are automatically available forHistoryBufinstances and are returning items in an order which does not reflect the write order and will likely surprise users which did not carefully read all the documentation forHistoryBuflike me.