Skip to content

fix newline handling for Windows in database configuration setup #320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 11, 2024
Merged

fix newline handling for Windows in database configuration setup #320

merged 1 commit into from
Mar 11, 2024

Conversation

gvozdvmozgu
Copy link
Contributor

@gvozdvmozgu gvozdvmozgu commented Mar 7, 2024 •
edited by jxs
Loading

And use trim() instead of pop() to parse user input

jxs
jxs approved these changes Mar 11, 2024
View reviewed changes
Copy link
Member

@jxs jxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, and thanks for this! ❤️

@jxs jxs merged commit 1e2411c into rust-db:main Mar 11, 2024
@gvozdvmozgu gvozdvmozgu deleted the fix-newline-handling-windows-config-setup branch March 13, 2024 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jxs jxs jxs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gvozdvmozgu @jxs