Implement scantxoutset method and test #428
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
@tcharding can you have a look at this? I'll fix the merge conflicts when I address any review comments. |
Member
|
Will review this monster when I"m back home. |
tcharding
reviewed
Jan 15, 2026
tcharding
reviewed
Jan 15, 2026
tcharding
reviewed
Jan 15, 2026
tcharding
reviewed
Jan 15, 2026
tcharding
reviewed
Jan 15, 2026
Member
|
Reviewed ca3a0fa The commit author is showing as Gideon and so is the co-authored-by tag. |
jamillambert
force-pushed
the
scantxoutset
branch
from
ca3a0fa to
fce63a5
Compare
Collaborator
Author
|
Suggested changes all made and resolved merge conflicts. |
tcharding
reviewed
Jan 15, 2026
types/src/v19/blockchain/into.rs
Outdated
Comment on lines
279
to
281
| tx_outs: Some(self.txouts), | ||
| height: Some(self.height), | ||
| best_block: Some(bestblock), |
Member
There was a problem hiding this comment.
Missed txouts and bestblock here mate.
Collaborator
Author
There was a problem hiding this comment.
Thanks, hopefully that's all of them.
tcharding
reviewed
Jan 15, 2026
types/src/v28/blockchain/into.rs
Outdated
| amount, | ||
| coinbase: Some(self.coinbase), | ||
| height: self.height, | ||
| block_hash: Some(blockhash), |
Member
There was a problem hiding this comment.
Suggested change
| block_hash: Some(blockhash), | |
| block_hash: Some(block_hash), |
Member
|
Reviewed fce63a5 |
jamillambert
force-pushed
the
scantxoutset
branch
from
fce63a5 to
a7415e6
Compare
The method is marked as experimental and was not implemented. Implement the method and all the changes up to v30. Co-authored-by: Jamil Lambert <[email protected]>
jamillambert
force-pushed
the
scantxoutset
branch
from
a7415e6 to
1e51177
Compare
tcharding
approved these changes
Jan 15, 2026
Member
|
I removed the mentions from the PR description. They are flagged by the merge script. FTR this is so that if/when people fork this repo and pick up the PR in their fork the mentioned dev doesn't get spammed with notifications. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method is marked as experimental and was not implemented.
Implement the method and all the changes up to v30.
Original PR is #164 by GideonBature. Picked up and fixed by jamillambert.