Skip to content

Minor LSP fixups #680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 21, 2024
Merged

Minor LSP fixups #680

merged 1 commit into from
Mar 21, 2024

Conversation

tgolsson
Copy link
Contributor

  • A formatting error in a detail
  • I started writing a rune mode for emacs (again...), and noticed that returning a u64 as the data is out of spec -- only u32/i32 are legal. This causes emacs to barf because the JSON parser there assumes i64 as the integer value. This data doesn't seem to be used, but at least this transform is reversible if we want it.
  • I noticed that completing json:: didn't include json:: as the prefix, leading to very odd results. I think the symbol-heuristic is a bit too naive still, but this is a tiny bit better. For example, completing the example would lead to json::json::from_string, whereas now it'll correctly only have json::to_string

@udoprog udoprog added the bug Something isn't working label Mar 21, 2024
@udoprog udoprog self-assigned this Mar 21, 2024
@udoprog udoprog merged commit fc2bc0c into rune-rs:main Mar 21, 2024
@udoprog
Copy link
Collaborator

udoprog commented Mar 21, 2024

Thanks for giving this some attention!

@tgolsson tgolsson deleted the ts/lsp-fixes branch March 21, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants