fix(ci): fix workflows to run when required to avoid empty required c… #3342
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamengual
reviewed
Apr 20, 2023
Comment on lines
+29
to
+30
| - '**.go' | ||
| - '**.js' |
There was a problem hiding this comment.
why we are adding and then at the same time ignoring here?
There was a problem hiding this comment.
Good catch. We don't want to ignore here, only in the *-required flows.
jamengual
approved these changes
Apr 20, 2023
This was referenced Apr 21, 2023
1 task
nitrocode
pushed a commit
that referenced
this pull request
May 5, 2023
…hecks (#3342) * fix(ci): fix workflows to run when required to avoid empty required checks
mtavaresmedeiros
pushed a commit
to mtavaresmedeiros/atlantis
that referenced
this pull request
Jul 3, 2023
…hecks (runatlantis#3342) * fix(ci): fix workflows to run when required to avoid empty required checks
ijames-gc
pushed a commit
to gocardless/atlantis
that referenced
this pull request
Feb 13, 2024
…hecks (runatlantis#3342) * fix(ci): fix workflows to run when required to avoid empty required checks
ijames-gc
pushed a commit
to gocardless/atlantis
that referenced
this pull request
Feb 13, 2024
…hecks (runatlantis#3342) * fix(ci): fix workflows to run when required to avoid empty required checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…hecks
what
This adjusts our workflows to run in more cases that are deemed relative to the required check or not. It's a bit more comprehensive and less targeted.
why
We have certain GHA workflows that we are required to pass before we allow Pull Requests to merge. However, some workflows are not triggered in certain cases which results in a PR being "stuck" due to a workflow being required without any build getting queued up.
tests
references
Similar to #3267