Skip to content

feat: more container labels: licenses #2900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Jan 16, 2023
Merged

feat: more container labels: licenses #2900

merged 11 commits into from
Jan 16, 2023

Conversation

nitrocode
Copy link
Member

@nitrocode nitrocode commented Dec 30, 2022 •
edited
Loading

what

  • add licenses label

why

  • The license in this repo is unofficial since it was modified to add hootsuite. Therefore the meta action does not pick it up and instead shows NOASSERTION as its value. This overrides that incorrect value to show the Apache 2.0 license.

tests

  • I have tested my changes by confirming the license is detected correctly

references

@nitrocode nitrocode requested a review from a team as a code owner December 30, 2022 06:40
@nitrocode nitrocode marked this pull request as draft December 30, 2022 06:45
@nitrocode nitrocode changed the title feat: more container labels: license feat: more container labels: licenses Dec 30, 2022
nitrocode
nitrocode commented Dec 30, 2022
View reviewed changes
nitrocode
nitrocode commented Dec 30, 2022
View reviewed changes
nitrocode
nitrocode commented Dec 30, 2022
View reviewed changes
nitrocode
nitrocode commented Dec 30, 2022
View reviewed changes
chenrui333
chenrui333 reviewed Jan 2, 2023
View reviewed changes
chenrui333
chenrui333 reviewed Jan 2, 2023
View reviewed changes
@nitrocode nitrocode requested a review from chenrui333 January 11, 2023 21:51
@nitrocode nitrocode marked this pull request as ready for review January 11, 2023 21:52
@nitrocode nitrocode merged commit d736250 into main Jan 16, 2023
@nitrocode nitrocode deleted the more-labels branch January 16, 2023 21:57
@nitrocode nitrocode added this to the v0.22.3 milestone Jan 16, 2023
@albertorm95 albertorm95 mentioned this pull request May 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamengual jamengual jamengual approved these changes

@chenrui333 chenrui333 Awaiting requested review from chenrui333

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.22.3
Development

Successfully merging this pull request may close these issues.
3 participants
@nitrocode @chenrui333 @jamengual