Still gets a comment for a non-existent project when --silence-no-projects flag is used

[raymondchen625]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request. Searching for pre-existing feature requests helps us consolidate datapoints for identical requirements into a single place, thank you!
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.
• If you are interested in working on this issue or have submitted a pull request, please leave a comment.

---

Overview of the Issue

Setting ATLANTIS_SILENCE_NO_PROJECTS=true still gets a no project... comment from atlantis.

Reproduction Steps

My atlantis has environment variable ATLANTIS_SILENCE_NO_PROJECTS=true. When I leave a comment atlantis plan -p non_existent in the PR, I still get a Plan Error comment from atlantis with message no project with name "non_existent" is defined in atlantis.yaml.

Logs

2023-03-06T15:47:42.573Z
no project with name "non_existent" is defined in atlantis.yaml
github.com/runatlantis/atlantis/server/events.(*PullUpdater).updatePull
	github.com/runatlantis/atlantis/server/events/pull_updater.go:17
github.com/runatlantis/atlantis/server/events.(*PlanCommandRunner).run
	github.com/runatlantis/atlantis/server/events/plan_command_runner.go:175
github.com/runatlantis/atlantis/server/events.(*PlanCommandRunner).Run
	github.com/runatlantis/atlantis/server/events/plan_command_runner.go:247
github.com/runatlantis/atlantis/server/events.(*DefaultCommandRunner).RunCommentCommand
	github.com/runatlantis/atlantis/server/events/command_runner.go:296
2023-03-06T15:47:42.096Z
Error building plan commands: no project with name "non_existent" is defined in atlantis.yaml
github.com/runatlantis/atlantis/server/events.(*InstrumentedProjectCommandBuilder).BuildPlanCommands
	github.com/runatlantis/atlantis/server/events/instrumented_project_command_builder.go:69
github.com/runatlantis/atlantis/server/events.(*PlanCommandRunner).run
	github.com/runatlantis/atlantis/server/events/plan_command_runner.go:170
github.com/runatlantis/atlantis/server/events.(*PlanCommandRunner).Run
	github.com/runatlantis/atlantis/server/events/plan_command_runner.go:247
github.com/runatlantis/atlantis/server/events.(*DefaultCommandRunner).RunCommentCommand
	github.com/runatlantis/atlantis/server/events/command_runner.go:296
...

Environment details

Atlantis version: v0.21.0
Atlantis flag:
ATLANTIS_SILENCE_NO_PROJECTS: true

Additional Context

This should be caused by the method PlanCommandRunner.run(), when a returned err!=nil, it always calls the p.pullUpdater.updatePull(ctx, cmd, command.Result{Error: err}) to leave comments in the PR regardless with the cause of the error and the silence-no-projects flag. A quick fix would be similar to this:

		if !(p.SilenceNoProjects && strings.Contains(err.Error(), "no project with name ")) {
			p.pullUpdater.updatePull(ctx, cmd, command.Result{Error: err})
		}

This also happens in a similar location of apply_command_runner.go.

[jamengual]

PRs are welcome. did you test 0.23.2?

…

On Mon, Mar 6, 2023 at 2:58 PM Raymond Chen ***@***.***> wrote: Community Note - Please vote on this issue by adding a 👍 reaction <https://blog.github.com/2016-03-10-add-reactions-to-pull-requests-issues-and-comments/> to the original issue to help the community and maintainers prioritize this request. Searching for pre-existing feature requests helps us consolidate datapoints for identical requirements into a single place, thank you! - Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request. - If you are interested in working on this issue or have submitted a pull request, please leave a comment. ------------------------------ Overview of the Issue Setting ATLANTIS_SILENCE_NO_PROJECTS=true still gets a no project... comment from atlantis. Reproduction Steps My atlantis has environment variable ATLANTIS_SILENCE_NO_PROJECTS=true. When I leave a comment atlantis plan -p non_existent in the PR, I still get a Plan Error comment from atlantis with message no project with name "non_existent" is defined in atlantis.yaml. Logs 2023-03-06T15:47:42.573Z no project with name "non_existent" is defined in atlantis.yamlgithub.com/runatlantis/atlantis/server/events.(*PullUpdater).updatePull github.com/runatlantis/atlantis/server/events/pull_updater.go:17github.com/runatlantis/atlantis/server/events.(*PlanCommandRunner).run github.com/runatlantis/atlantis/server/events/plan_command_runner.go:175github.com/runatlantis/atlantis/server/events.(*PlanCommandRunner).Run github.com/runatlantis/atlantis/server/events/plan_command_runner.go:247github.com/runatlantis/atlantis/server/events.(*DefaultCommandRunner).RunCommentCommand github.com/runatlantis/atlantis/server/events/command_runner.go:296 2023-03-06T15:47:42.096Z <http://github.com/runatlantis/atlantis/server/events/command_runner.go:2962023-03-06T15:47:42.096Z> Error building plan commands: no project with name "non_existent" is defined in atlantis.yamlgithub.com/runatlantis/atlantis/server/events.(*InstrumentedProjectCommandBuilder).BuildPlanCommands github.com/runatlantis/atlantis/server/events/instrumented_project_command_builder.go:69github.com/runatlantis/atlantis/server/events.(*PlanCommandRunner).run github.com/runatlantis/atlantis/server/events/plan_command_runner.go:170github.com/runatlantis/atlantis/server/events.(*PlanCommandRunner).Run github.com/runatlantis/atlantis/server/events/plan_command_runner.go:247github.com/runatlantis/atlantis/server/events.(*DefaultCommandRunner).RunCommentCommand github.com/runatlantis/atlantis/server/events/command_runner.go:296 ... Environment details Atlantis version: v0.21.0 Atlantis flag: ATLANTIS_SILENCE_NO_PROJECTS: true Additional Context This should be caused by the method PlanCommandRunner.run() <https://github.com/runatlantis/atlantis/blob/5be47fb82a6e7d580acabcfdcf8d36710ba6b1fb/server/events/plan_command_runner.go#L198>, when a returned err!=nil, it always calls the p.pullUpdater.updatePull(ctx, cmd, command.Result{Error: err}) to leave comments in the PR regardless with the cause of the error and the silence-no-projects flag. A quick fix would be similar to this: if !(p.SilenceNoProjects && strings.Contains(err.Error(), "no project with name ")) { p.pullUpdater.updatePull(ctx, cmd, command.Result{Error: err}) } This also happens in a similar location of apply_command_runner.go. — Reply to this email directly, view it on GitHub <#3192>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAQ3ERCDS3BLPWAXRSTVZKLW2ZTYDANCNFSM6AAAAAAVRXIRIE> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[raymondchen625]

I haven't tried 0.23.2. But looking at its code and the main's, they are pretty much the same. Comparing strings in the error message seems hacky. I'm not able to come up with a cleaner approach yet.

[krrrr38]

@raymondchen625 You mean non_existent is not exist directory?

--silence-no-projects flag doesn't handle this situation. It handle if modified files doesn't match to any projects, atlantis ignore the PR.

--silence-no-projects will tell Atlantis to ignore PRs if none of the modified files are part of a project defined in the atlantis.yaml file.

https://www.runatlantis.io/docs/server-configuration.html#silence-no-projects

If you want to ignore not existed directory, atlantis requires other flag and implementation which is not provided yet.

[raymondchen625]

You mean non_existent is not exist directory?

No, I meant not exist project. Our repo is configured with 2 atlantis webhooks, one staging and the other production. So when I comment atlantis plan -p production, both atlantis instances receive the webhook call. This is my atlantis.yaml in my staging:

version: 3
projects:
- name: staging
  dir: .
  workflow: staging
  terraform_version: v1.3.2
  autoplan:
    enabled: false

Since project production is not defined for this staging atlantis instance, I wish it could just ignore it without making any comment to the PR. Is that possible?

[raymondchen625]

We found upgrading to v0.23.2 fixed it. Should be related to #2969. Thanks.