Skip to content

Conversation

@mattref
Copy link
Contributor

@mattref mattref commented Oct 27, 2025

Description

By default, when using Bedrock Guardrails alongside ConverseStream requests, the guardrails operate in "Synchronous mode", which may or may not be desired.

This PR adds a new attribute, guardrail_stream_processing_mode, to BedrockConverse, allowing users to configure the streaming response behavior when using guardrails in a streaming fashion.

Supporting Documentation:

Related:

Version Bump?

Did I bump the version in the pyproject.toml file of the package I am updating? (Except for the llama-index-core package)

  • Yes
  • No

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Your pull-request will likely not be merged unless it is covered by some form of impactful unit testing.

  • I added new unit tests to cover this change
  • I believe this change is already covered by existing unit tests

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added Google Colab support for the newly added notebooks.
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I ran uv run make format; uv run make lint to appease the lint gods

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Oct 27, 2025
Comment on lines 701 to 715
not in [
"tools",
"guardrail_identifier",
"guardrail_version",
"trace",
"thinking",
]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't feel that there was a need to add guardrail_stream_processing_mode here, as it's not pulled from kwargs.

To be fair, I'm also not too sure why guardrail_identifier and guardrail_version were put here either

@mattref
Copy link
Contributor Author

mattref commented Oct 27, 2025

Not too sure about the failed prettier linting 😅

Copy link
Member

@AstraBert AstraBert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 28, 2025
@AstraBert
Copy link
Member

For linting, I advise running:

uv pip install pre-commit
pre-commit install
pre-commit run -a
git add .
git commit -m "ci: lint" # linting is now applied at commit time by pre-commit hooks
git push <your-origin> <your-branch>

@mattref mattref force-pushed the bedrock-converse-guardrail-stream-processing-mode branch from 4d6bc86 to e2cc73a Compare October 28, 2025 23:20
@mattref
Copy link
Contributor Author

mattref commented Oct 28, 2025

@AstraBert Thanks for the review! I just rebased the branch & bumped the version to 0.10.7 instead of the original 0.10.6.

Regarding the linting, it looked good on my end hence why I was confused about the "prettier" failure 😅

edit: Looks like it's passing now anyways 🤷‍♂️

@AstraBert
Copy link
Member

Yeah, most of the times you just need to update your branch to make these "unexplainable" linting problems go away :)

@AstraBert AstraBert merged commit cddd290 into run-llama:main Oct 29, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants