Skip to content

Conversation

@Sun-ZhenXing
Copy link
Contributor

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #20085 (issue)

New Package?

Did I fill in the tool.llamahub section in the pyproject.toml and provide a detailed README.md for my new integration or package?

  • Yes
  • No

Version Bump?

Did I bump the version in the pyproject.toml file of the package I am updating? (Except for the llama-index-core package)

  • Yes
  • No

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Your pull-request will likely not be merged unless it is covered by some form of impactful unit testing.

  • I added new unit tests to cover this change
  • I believe this change is already covered by existing unit tests

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added Google Colab support for the newly added notebooks.
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I ran uv run make format; uv run make lint to appease the lint gods

Copilot AI review requested due to automatic review settings October 14, 2025 10:22
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request fixes a bug in the Milvus vector store implementation where sparse_embedding_field.get_field_kwargs() was incorrectly being called instead of sparse_embedding_function.get_field_kwargs().

Key Changes

  • Fixed incorrect attribute name from sparse_embedding_field to sparse_embedding_function in the _add_fields_to_schema method

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Oct 14, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 14, 2025
@AstraBert
Copy link
Member

Hey @Sun-ZhenXing, we need to bump the version of the integration to publish this package :)

@Sun-ZhenXing
Copy link
Contributor Author

@AstraBert Sorry, I'm still not very familiar with the process. So can I update the llama-index-vector-stores-milvus version to generate a new release?

@AstraBert
Copy link
Member

@AstraBert Sorry, I'm still not very familiar with the process. So can I update the llama-index-vector-stores-milvus version to generate a new release?

Yes, correct, you just need to update the version there, the rest will be taken care of by our CI/CD pipeline when we merge :)

@Sun-ZhenXing
Copy link
Contributor Author

@AstraBert I have update the version here.

@AstraBert AstraBert enabled auto-merge (squash) October 15, 2025 12:26
@AstraBert AstraBert merged commit 2f22f37 into run-llama:main Oct 15, 2025
11 checks passed
@Sun-ZhenXing Sun-ZhenXing deleted the alexsun branch October 16, 2025 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Milvus call get_field_kwargs() Error

2 participants