-
Notifications
You must be signed in to change notification settings - Fork 6.5k
fix: Milvus get_field_kwargs() #20086
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request fixes a bug in the Milvus vector store implementation where sparse_embedding_field.get_field_kwargs() was incorrectly being called instead of sparse_embedding_function.get_field_kwargs().
Key Changes
- Fixed incorrect attribute name from
sparse_embedding_fieldtosparse_embedding_functionin the_add_fields_to_schemamethod
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
Hey @Sun-ZhenXing, we need to bump the version of the integration to publish this package :) |
|
@AstraBert Sorry, I'm still not very familiar with the process. So can I update the llama-index-vector-stores-milvus version to generate a new release? |
Yes, correct, you just need to update the version there, the rest will be taken care of by our CI/CD pipeline when we merge :) |
|
@AstraBert I have update the version here. |
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes #20085 (issue)
New Package?
Did I fill in the
tool.llamahubsection in thepyproject.tomland provide a detailed README.md for my new integration or package?Version Bump?
Did I bump the version in the
pyproject.tomlfile of the package I am updating? (Except for thellama-index-corepackage)Type of Change
Please delete options that are not relevant.
How Has This Been Tested?
Your pull-request will likely not be merged unless it is covered by some form of impactful unit testing.
Suggested Checklist:
uv run make format; uv run make lintto appease the lint gods