web: Add way to check for initialization for tests that check for no polyfilling #22490
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielhjacobs
added
A-web
danielhjacobs
force-pushed
the
proof-of-concept-polyfill-finished
branch
4 times, most recently
from
2d0e22c to
7e75a1d
Compare
danielhjacobs
force-pushed
the
proof-of-concept-polyfill-finished
branch
from
7e75a1d to
7c01059
Compare
danielhjacobs
changed the title
danielhjacobs
changed the title
danielhjacobs
added
T-refactor
Contributor
Author
|
Note: This adds to the PublicAPI a new boolean initialized, which is set to true when Ruffle has done all its polyfilling. That's arguably a good thing, I can see this variable being useful to certain people. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can be used for tests that check if polyfilling occur too and for those should eliminate the need to wait for ruffle-embed/ruffle-object to exist before continuing but at the same time for those tests perhaps checking those elements exist may be considered a better condition for which to wait anyway, since that's when the tests should have their expected.html anyway.