wgpu: Fix pixel copying when processing pixelbender output #22394
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lord-McSweeney
added
A-rendering
Member
|
I think crafting a test for this should be pretty simple |
Lord-McSweeney
added
the
waiting-on-author
SuchAFuriousDeath
changed the title
SuchAFuriousDeath
force-pushed
the
wgpu-pixelbender-fix
branch
from
fccc4d7 to
eb7b5bb
Compare
Lord-McSweeney
removed
the
waiting-on-author
SuchAFuriousDeath
force-pushed
the
wgpu-pixelbender-fix
branch
from
eb7b5bb to
c93509c
Compare
kjarosh
force-pushed
the
wgpu-pixelbender-fix
branch
from
c93509c to
b9f3ec3
Compare
Hancock33
added a commit
to Hancock33/batocera.piboy
that referenced
this pull request
Dec 22, 2025
------------------------------------------------------------------------------------------ dolphin-emu.mk 87038101519dff1c0957594572c47baa37a6b733 # Version: Commits on Dec 22, 2025 ------------------------------------------------------------------------------------------ Merge branch 'release-prep-2512', ------------------------------------------------------------------------------------------ duckstation.mk 2935a3d71bdd7cef7a665fb9983e5562e24aac43 # Version: Commits on Dec 21, 2025 ------------------------------------------------------------------------------------------ Common: Add additional ryml helpers, ----------------------------------------------------------------------------------- eden.mk 3413fbd9da657a9b92398256ffe3bf3b4ac005ee # Version: Commits on Dec 22, 2025 ----------------------------------------------------------------------------------- [FIXUP] Partially revert "[NCE] Fix cache invalidation and signal interrupt race condition (#3063)" (#3190) ------------------------------------------------------------------------------------- hatari.mk 56c8a4cbedb99b35b90896e12576a715368ae8ea # Version: Commits on Dec 21, 2025 ------------------------------------------------------------------------------------- m68k-linux: update to v6.18 kernel This contains fix for the m68k regression in v6.16-v6.17 kernels., -------------------------------------------------------------------------------------- melonds.mk 3a3388c4c50e8735af125c1af4d89e457f5e9035 # Version: Commits on Dec 21, 2025 -------------------------------------------------------------------------------------- fix building with disable wayland (#2513) QWaylandApplication definition doesn't exist on wayland disabled qt binaries, -------------------------------------------------------------------------------------- openmsx.mk 2b3997c090dd63f54d5eb71a79f716b95f14b5ae # Version: Commits on Dec 21, 2025 -------------------------------------------------------------------------------------- Fixed some details of these Canon machines. Description of V-8 incorrectly stated 8kB of RAM. But actual config was correct with 16kB. Also added release years based on MSX Resource Center Wiki., ------------------------------------------------- vice.mk r45920 # Version: Commits on Dec 22, 2025 ------------------------------------------------- do only call set_userport_flag() when wic64 is actually the active device, else the flag may get active when no, or another, user port device is active. neatly discovered by testprogs/C64/autostart/defaults/test.crt git-svn-id: https://svn.code.sf.net/p/vice-emu/code/trunk@45920 379a1393-f5fb-40a0-bcee-ef074d9b53f7, ------------------------------------------------------------------------------------------- xenia-canary.mk 169fea978a73fcb4537c2a6e2150a925a484361c # Version: Commits on Dec 18, 2025 ------------------------------------------------------------------------------------------- [XAM/XLIVE] - Set proper returns when offline - Have XLive functions return their offline values. - Have XGIUserReadStats return X_ONLINE_E_LOGON_NOT_LOGGED_ON, ------------------------------------------------------------------------------------------- xenia-native.mk 169fea978a73fcb4537c2a6e2150a925a484361c # Version: Commits on Dec 18, 2025 ------------------------------------------------------------------------------------------- [XAM/XLIVE] - Set proper returns when offline - Have XLive functions return their offline values. - Have XGIUserReadStats return X_ONLINE_E_LOGON_NOT_LOGGED_ON, ------------------------------------------------------------------------------------- ikemen.mk ee3d879bce7d83081ba08ac0620db225261044c3 # Version: Commits on Dec 22, 2025 ------------------------------------------------------------------------------------- Merge pull request #2992 from ikemen-engine/fix9 fix: persist life/music options, stats/survival bugs, and select.def music parsing, ------------------------------------------------------------------------------------------- moonlight-qt.mk 741e360024c42abb3c3aee831034931eb494a030 # Version: Commits on Dec 22, 2025 ------------------------------------------------------------------------------------------- Fix GLES compatibility check on VF2 pvr driver, --------------------------------------------------------------- ruffle.mk nightly-2025-12-22 # Version: Commits on Dec 22, 2025 --------------------------------------------------------------- ## What's Changed * chore: Update translations from Crowdin by @kjarosh in ruffle-rs/ruffle#22564 * core: Reduce some logging by @Lord-McSweeney in ruffle-rs/ruffle#22559 * wgpu: Fix pixel copying when processing pixelbender output by @SuchAFuriousDeath in ruffle-rs/ruffle#22394 * core/avm2: Make all uncaught errors go through `Avm2::uncaught_error` by @Lord-McSweeney in ruffle-rs/ruffle#22455 **Full Changelog**: ruffle-rs/ruffle@nightly-2025-12-21...nightly-2025-12-22, -------------------------------------------------------------------------------------- scummvm.mk 98efdf7d1da6573ecc00d63dc821142924f30d76 # Version: Commits on Dec 21, 2025 -------------------------------------------------------------------------------------- I18N: Update translation (Catalan) Currently translated at 87.3% (2673 of 3059 strings), --------------------------------------------------------------------------------------- thextech.mk 206350f8133a9e03dd8fcac76b1ea3f615f92a1a # Version: Commits on Dec 20, 2025 --------------------------------------------------------------------------------------- npc_generator.cpp: fix dev bug where generators might fail to trigger (Affected Cinematic Circuit in Another Adventure) (Introduced in 552045763a9643a5258d4d9b8c8b77fa498eeb33), ------------------------------------------------------------------------------------------ dxx-rebirth.mk 25db0a73478c933c80f590a49909b62a3ef8aa3b # Version: Commits on Dec 22, 2025 ------------------------------------------------------------------------------------------ Merge branch ai-load-default into master, ---------------------------------------------------------------------------------------- openmohaa.mk 46798d46dc43f1fed4990bb0fbf604a8fe8a698a # Version: Commits on Dec 20, 2025 ---------------------------------------------------------------------------------------- refactor(network): clarify net profiling struct and field names, ---------------------------------------------------------------------------------------- supertux2.mk 457fe16a2148d642075e4ef7577d64189f318bc6 # Version: Commits on Dec 22, 2025 ---------------------------------------------------------------------------------------- Fix several linter issues, ------------------------------------------------------------------------------------------------ libretro-mame-src.mk b013cabe6c3d9c17f30a2ff2e5f033ca254d4a61 # Version: Commits on Dec 22, 2025 ------------------------------------------------------------------------------------------------ Merge remote-tracking branch 'upstream/master', ----------------------------------------------------------------------------------- xone.mk 17d9b6a8939085d6e13b8c3ad684d28ca3166a02 # Version: Commits on Dec 21, 2025 ----------------------------------------------------------------------------------- Fix pairing through sysfs, ---------------------------------------------------------------------------------------- doomretro.mk 42f9b762c0013d633c7a915238e98c220aa6a01b # Version: Commits on Dec 22, 2025 ---------------------------------------------------------------------------------------- Revert previous commit Nope., -------------------------------------------------------------------------------------- vkquake.mk 6bfad760f5cb5c2f1ed5d5823aab57f062d85801 # Version: Commits on Dec 19, 2025 -------------------------------------------------------------------------------------- Cont'd #837: Rework replacement models management, cleaner an better (hopefully) Apply the following simple rules: - Replacement models are only loaded if the original is MDL - Replacement models are only loaded if their path_id is >= MDL, meaning there are either in the same .pak or as in additional path/.pak - External resources for a given replacement model are only loaded if their path_id >= replacement model - If both MD3 and MD5 replacement models exists, only the one with the highest path_id is loaded, with MD3 chosen in case of equality - Removed 'rogue' special treatment, this is not our job to fix Re-release probems and this special rule will bite us later if a mod use 'rogue' as a base..., ----------------------------------------------------------------------------------------- sonic3-air.mk ac400414e7228a2a1893aff2080cdef0f060025c # Version: Commits on Dec 21, 2025 ----------------------------------------------------------------------------------------- For Android file import, get the right file name, ---------------------------------------------------------------------------------- trx.mk de4db7abca4c8b69cbefc5b9c13a7301d581099d # Version: Commits on Dec 22, 2025 ---------------------------------------------------------------------------------- inv-ring: fix ring stuck when exiting to title, ----------------------------------------------------------------------------------------------- libretro-scummvm.mk 98efdf7d1da6573ecc00d63dc821142924f30d76 # Version: Commits on Dec 21, 2025 ----------------------------------------------------------------------------------------------- I18N: Update translation (Catalan) Currently translated at 87.3% (2673 of 3059 strings),
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the game mentioned at #12460 ('The End') for me and makes it playable (without the changes, a RangeError is thrown. However, the issue also mentions a separate error that does not occur for me (PR probably upcoming on that one too).
The texture format is Rgba32Float for both 3 and 4 channels, so the channel count should only be taken into account when copying the pixels in each row. Since channels_in_raw_pixels would be a constant, I also refactored the surrounding code a little bit.