-
Notifications
You must be signed in to change notification settings - Fork 0
chore: fix nodejs sample app #46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Akash Gupta <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #46 +/- ##
===========================================
- Coverage 88.82% 8.50% -80.32%
===========================================
Files 3 29 +26
Lines 170 1399 +1229
Branches 58 308 +250
===========================================
- Hits 151 119 -32
- Misses 17 1211 +1194
- Partials 2 69 +67 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Akash Gupta <[email protected]>
Co-authored-by: Akash Gupta <[email protected]>
Co-authored-by: Akash Gupta <[email protected]>
Co-authored-by: Akash Gupta <[email protected]>
Do we have to update the license ? |
That's a good question. In a lot of the public repos, we have moved to elastic license v2. Let's circle this back with @sivashanmukh once. |
I've added Node.js sample apps for JavaScript and TypeScript languages.
See the README.md files in the
examples/<app>
directory for more details.Note that the sample apps are now added in the root
examples
directory instead oftests/e2e
.I've also added steps to run the sample app against regenerated client libraries from both the production version of RudderTyper and the local working copy in the repository.
This will help us during development where we have to validate the changes quickly.
Apart from that the following major changes were made:
yarn
withnpm
throughout the repo (we have to update the docs if needed).husky
dependency for pre-commit hooks.These changes will now enable us to run RudderTyper tool in any terminal client.