Skip to content

Conversation

saikumarrs
Copy link
Member

@saikumarrs saikumarrs commented Aug 14, 2024

I've added Node.js sample apps for JavaScript and TypeScript languages.
See the README.md files in the examples/<app> directory for more details.

Note that the sample apps are now added in the root examples directory instead of tests/e2e.

I've also added steps to run the sample app against regenerated client libraries from both the production version of RudderTyper and the local working copy in the repository.
This will help us during development where we have to validate the changes quickly.

Apart from that the following major changes were made:

  • I replaced yarn with npm throughout the repo (we have to update the docs if needed).
  • Fixed GitHub workflows and added CODEOWNERS file.
  • Upgrade Node to the latest v20.x.x version.
  • Added husky dependency for pre-commit hooks.
  • Removed redundant e2e test setup as it was not applicable anymore.
  • Updated README.md in the root to the latest.
  • Upgraded all the dependencies to their latest versions and used absolute versions.

These changes will now enable us to run RudderTyper tool in any terminal client.

@saikumarrs saikumarrs self-assigned this Aug 14, 2024
Co-authored-by: Akash Gupta <[email protected]>
Copy link

codecov bot commented Aug 14, 2024

Codecov Report

Attention: Patch coverage is 1.60428% with 184 lines in your changes missing coverage. Please review.

Project coverage is 8.50%. Comparing base (b67f2f2) to head (0253036).

Files Patch % Lines
src/cli/commands/init.tsx 0.00% 37 Missing ⚠️
src/cli/commands/build.tsx 0.00% 23 Missing ⚠️
src/cli/api/api.ts 0.00% 13 Missing ⚠️
src/generators/gen.ts 0.00% 13 Missing ⚠️
src/cli/index.tsx 0.00% 11 Missing ⚠️
src/generators/javascript/javascript.ts 0.00% 11 Missing ⚠️
src/generators/swift/swift.ts 0.00% 10 Missing ⚠️
src/generators/objc/objc.ts 0.00% 9 Missing ⚠️
src/cli/commands/token.tsx 0.00% 8 Missing ⚠️
src/cli/api/trackingplans.ts 0.00% 7 Missing ⚠️
... and 16 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #46       +/-   ##
===========================================
- Coverage    88.82%   8.50%   -80.32%     
===========================================
  Files            3      29       +26     
  Lines          170    1399     +1229     
  Branches        58     308      +250     
===========================================
- Hits           151     119       -32     
- Misses          17    1211     +1194     
- Partials         2      69       +67     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@saikumarrs saikumarrs marked this pull request as ready for review August 18, 2024 15:36
@saikumarrs saikumarrs requested a review from MoumitaM August 20, 2024 09:14
@akashrpo
Copy link
Contributor

Do we have to update the license ?

@saikumarrs saikumarrs requested a review from akashrpo August 20, 2024 13:07
@saikumarrs
Copy link
Member Author

Do we have to update the license ?

That's a good question. In a lot of the public repos, we have moved to elastic license v2. Let's circle this back with @sivashanmukh once.

@saikumarrs saikumarrs merged commit d643416 into develop Aug 21, 2024
5 checks passed
@akashrpo akashrpo deleted the chore.nodejs-sample-app-sdk-2249 branch August 21, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants