Skip to content

Conversation

atzoum
Copy link
Contributor

@atzoum atzoum commented Sep 18, 2025

Description

Redis throttler configuration collides with throttling configuration for REDIS destination, since viper treats yaml configuration keys in a case-insensitive manner

Linear Ticket

resolves PIPE-2412

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

Copy link

codecov bot commented Sep 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (release/1.59.x@0725a55). Learn more about missing BASE report.

Additional details and impacted files
@@                Coverage Diff                @@
##             release/1.59.x    #6365   +/-   ##
=================================================
  Coverage                  ?   77.67%           
=================================================
  Files                     ?      523           
  Lines                     ?    70242           
  Branches                  ?        0           
=================================================
  Hits                      ?    54559           
  Misses                    ?    12839           
  Partials                  ?     2844           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@atzoum atzoum merged commit c8cedd5 into release/1.59.x Sep 19, 2025
61 checks passed
@atzoum atzoum deleted the fix.redisConfigCollision branch September 19, 2025 05:06
atzoum pushed a commit that referenced this pull request Sep 19, 2025
🤖 I have created a release *beep* *boop*
---


##
[1.59.3](v1.59.2...v1.59.3)
(2025-09-19)


### Bug Fixes

* naming collision in redis throttling configuration
([#6365](#6365))
([c8cedd5](c8cedd5))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
atzoum added a commit that referenced this pull request Sep 19, 2025
# Description

Syncing patch release v1.59.3 to main branch

**↓↓ Please review and edit commit overrides before merging ↓↓**

BEGIN_COMMIT_OVERRIDE
fix: naming collision in redis throttling configuration (#6365)
END_COMMIT_OVERRIDE

---------

Co-authored-by: Dilip Kola <[email protected]>
Co-authored-by: Akash Chetty <[email protected]>
Co-authored-by: Francesco Casula <[email protected]>
Co-authored-by: Aris Tzoumas <[email protected]>
Co-authored-by: Aris Tzoumas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants