Skip to content

chore: update keydb dependency #6222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

chore: update keydb dependency #6222

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ require (
github.com/rudderlabs/analytics-go v3.3.3+incompatible
github.com/rudderlabs/bing-ads-go-sdk v0.2.3
github.com/rudderlabs/compose-test v0.1.3
github.com/rudderlabs/keydb v0.1.0-alpha
github.com/rudderlabs/keydb v0.2.0-alpha
github.com/rudderlabs/rudder-go-kit v0.59.4
github.com/rudderlabs/rudder-observability-kit v0.0.4
github.com/rudderlabs/rudder-schemas v0.7.0
Expand Down
4 changes: 2 additions & 2 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1199,8 +1199,8 @@ github.com/rudderlabs/compose-test v0.1.3 h1:uyep6jDCIF737sfv4zIaMsKRQKX95IDz5Xb
github.com/rudderlabs/compose-test v0.1.3/go.mod h1:tuvS1eQdSfwOYv1qwyVAcpdJxPLQXJgy5xGDd/9XmMg=
github.com/rudderlabs/goqu/v10 v10.3.1 h1:rnfX+b4EwBWQ2UQfIGeEW299JBBkK5biEbnf7Kq4/Gg=
github.com/rudderlabs/goqu/v10 v10.3.1/go.mod h1:LH2vI5gGHBxEQuESqFyk5ZA2anGINc8o25hbidDWOYw=
github.com/rudderlabs/keydb v0.1.0-alpha h1:h87QGW9ut6jQExQjtZsp2BxPc0Hix58WELQ5OrzialM=
github.com/rudderlabs/keydb v0.1.0-alpha/go.mod h1:gnyirkn1FWIQPCvo/E6rFmfDQ2pjVkAYHF3hJvsBpC0=
github.com/rudderlabs/keydb v0.2.0-alpha h1:LcjiKWewZIO6OLeUvWwte8Qe3VeD1+/5jhzpHM7ZzVk=
github.com/rudderlabs/keydb v0.2.0-alpha/go.mod h1:7a49ZEx7gtZJYP9/sZoYQk2F3GlFaSoX3oubkyn+Hu8=
github.com/rudderlabs/parquet-go v0.0.3 h1:/zgRj929pGKHsthc0kw8stVEcFu1JUcpxDRlhxjSLic=
github.com/rudderlabs/parquet-go v0.0.3/go.mod h1:WmwBOdvwpXl2aZGRk3NxxgzC/DaWGfax3jrCRhKhtSo=
github.com/rudderlabs/rudder-go-kit v0.59.4 h1:iKtxLhRLvrfwck53l/2ZM1bnykuJ41l1ohreUpR9l6E=
Expand Down
12 changes: 5 additions & 7 deletions services/dedup/dedup_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ import (
"golang.org/x/sync/errgroup"
"google.golang.org/grpc"

keydbcache "github.com/rudderlabs/keydb/cache"
keydbclient "github.com/rudderlabs/keydb/client"
keydb "github.com/rudderlabs/keydb/node"
keydbproto "github.com/rudderlabs/keydb/proto"
Expand Down Expand Up @@ -395,12 +394,8 @@ func startKeydb(t testing.TB, conf *config.Config) {
SnapshotInterval: time.Minute,
Addresses: []string{address},
}
cf := func(hashRange uint32) (keydb.Cache, error) {
conf.Set("BadgerDB.Dedup.Path", t.TempDir())
return keydbcache.BadgerFactory(conf, logger.NOP)(hashRange)
}
require.NoError(t, err)
service, err = keydb.NewService(ctx, nodeConfig, cf, &mockedCloudStorage{}, logger.NOP)
service, err = keydb.NewService(ctx, nodeConfig, &mockedCloudStorage{}, conf, stats.NOP, logger.NOP)
require.NoError(t, err)

// Create a gRPC server
Expand Down Expand Up @@ -444,7 +439,10 @@ func (m *mockedFilemanagerSession) Next() (fileObjects []*filemanager.FileInfo,

type mockedCloudStorage struct{}

func (m *mockedCloudStorage) Download(_ context.Context, _ io.WriterAt, _ string) error { return nil }
func (m *mockedCloudStorage) Download(_ context.Context, _ io.WriterAt, _ string, options ...filemanager.DownloadOption) error {
return nil
}

func (m *mockedCloudStorage) UploadReader(_ context.Context, _ string, _ io.Reader) (filemanager.UploadedFile, error) {
return filemanager.UploadedFile{}, nil
}
Expand Down
Loading