chore: remove enableV2NotifierJob flag support #6196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shekhar-rudder
force-pushed
the
war-476-remove-column2
branch
2 times, most recently
from
111b930 to
b99bcc6
Compare
shekhar-rudder
force-pushed
the
war-476-remove-column2
branch
from
b99bcc6 to
4d5748d
Compare
achettyiitr
approved these changes
Jul 30, 2025
vyeshwanth
reviewed
Jul 31, 2025
| @@ -300,13 +300,13 @@ func scanJob(scan scanFn, job *Job) error { | |||
| } | |||
| if jobTypeRaw.Valid { | |||
There was a problem hiding this comment.
do we allow nulls for jobtype?
There was a problem hiding this comment.
Yes. There is no NON NULL constraint for job_type column
vyeshwanth
reviewed
Jul 31, 2025
| While not ideal, this is acceptable given that there won't be many such jobs. | ||
| */ | ||
| job.loadfile.AllowUploadV2JobCreation(job.DTO()) | ||
| job.config.alwaysRegenerateAllLoadFiles |
There was a problem hiding this comment.
With notifier v2 upload job being the default we should always regenerate the files right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR gets rid of the
enableV2NotifierJobflag. Going forward all the notifier jobs will of the V2 type.Security