Fix formatting of the #company_descriptive_date filed

[chubchenko]

Overview

In the previous release, the #stringify_with_same_day method was changed. After that, company_descriptive_date started having different formatting when creating the ACH file.

To prove that I have added a test and attached a screenshot below.

[henriquegasques]

Thanks for reporting the issue. The only problem is that this f value may not be a Date, it really can be any 6 characters according to the ACH specs.

What I believe we should do is make sure it's always 6 characters (which is what I thought strptime would do, my bad..) something like:

Suggested change

	f.strftime('%y%m%d')
	rescue
	f
	f = Date.parse(f) unless f.is_a? Date
	f.strftime('%y%m%d')
	rescue
	f.rjust(6, " ")

[henriquegasques]

Updated the comment because we might want to do parse only if it's not a date.

[chubchenko]

I understand your goal but there are a few problems

• f can be Time or DateTime
• in case if f match to /^SD\d+$/ (e.g. SD12345)

Also, from the definition of the .field method, I see that it supports validation, maybe this is a more appropriate place for it?

[henriquegasques]

The case for SDhhmm strings is handled on line 5

[henriquegasques]

The company_descriptive_date field of the batch header is optional and alphanumeric, it doesn't have to be parse-able, so I don't see how we could validate it as it really can be any 6 characters

[henriquegasques]

I believe this covers all the cases:

Suggested change

	f.strftime('%y%m%d')
	rescue
	f
	f = Date.parse(f) unless f.respond_to?(:strftime)
	f.strftime('%y%m%d')
	rescue
	f.to_s.rjust(6, ' ')
	end

It will:

• Try to parse the date only if f does not already respond to strftime
• If it fails, pad the string with spaces up to 6 characters

What do you think @chubchenko?