Skip to content
This repository was archived by the owner on Dec 4, 2023. It is now read-only.

Upgrade to v8 4.5 #178

Merged
merged 129 commits into from
May 13, 2016
Merged

Upgrade to v8 4.5 #178

merged 129 commits into from
May 13, 2016

Conversation

cowboyd
Copy link
Collaborator

@cowboyd cowboyd commented Jul 3, 2015

This upgrades to the 4.5 build process which uses the Chromium depot tools.

This completely removes the v8 source as a submodule and instead uses fetch and gclient sync to configure all build dependencies.

ignisf added 30 commits June 10, 2014 14:19
@ignisf
Bump v8 version to 3.27.23
f5ebcfe
@ignisf
Remove unnecessary files from the gem
b5a4394
@ignisf
Bring patchset up to speed with 3.27.23
c0c27e2
@ignisf
Add submodule dependencies and update v8
9eee915 
Add submodules for icu and Chrome's build tools and bump the v8 version
to 3.27.23.1
@ignisf
Link v8 dependency dirs to submodule directories
4ec06f8
@ignisf
Simplify checkout and patch processes
62c010a
@ignisf
GCC 4.9 is a supported compiler
1a4c478
@ignisf
Silence warnings
f7e706e
@ignisf
Specify the correct directory for the patches
3c143f8
@ignisf
Route build warnings to stdout
7622b9d
@ignisf
Update Travis configuration
44b4e40 
Add REE, Ruby 2.1.2 and Rubinius 2
@ignisf
Bump v8 to 3.27.24
3cc2340
@ignisf
Remove git-svn from Travis configuration
108c3c7
@ignisf
Add new submodules to the clean task
68fca9a
@ignisf
Bump v8 to 3.27.28
8170ba3
@ignisf
Simplify Rakefile
6252277
@ignisf
Attempt to work around 10 minute Travis build limit
d198236
@ignisf
Remove unused checkout logic
1ba8077
@ignisf
Cosmetic changes to the Rakefile
0e9aa52
@ignisf
Run bundle install concurrently on Travis
3034f80
@ignisf
Refactor the compiler detection module
80a8dc0
@ignisf
Add specs for the compiler classes
4a0b861
@ignisf
Extract the CompilerHelpers module to spec/support
ac4ea12
@ignisf
The RSpec spies syntax is now available by default
1a9cbd5
@ignisf
For now we're still using RSpec 2.14
3a842d9
@ignisf
Do not use new hash literal syntax
a1314e5
@ignisf
Escape command before interpolating in Regexp
c226b41
@ignisf
Fix a bug in compiler version parsing
ead7283
@ignisf
Add Apple LLVM compiler
7b185f4
@ignisf
Change spec wording
f142f28
@cowboyd
Copy link
Collaborator Author

cowboyd commented Jul 13, 2015

Sheesh. I'm the guy who fights always fights with the v8 build and ends up on the floor unconsious.

There is a standalone_static_library option referenced in gyp/generators/make.py, that can be turned on somehow. I thought I'd figured it out, but apparently not. If we can somehow turn that on, then we can actually build linux binaries.

@ignisf
Copy link
Collaborator

ignisf commented Jul 13, 2015

It was a tough one...

-rw-r--r--  1 ignisf ignisf  10M 13 юли 15,29 libv8-4.5.95.5-x86_64-linux.gem

@cowboyd
Copy link
Collaborator Author

cowboyd commented Jul 13, 2015

You magnificent bastard.

you got me you beautiful bastard _c79b658e8e1f7e21575aa9d9e7533b56

@cowboyd
Merge pull request #185 from cowboyd/build-standalone-static-library
020b648 
Instruct GYP to create a standalone static library
@cowboyd
Copy link
Collaborator Author

cowboyd commented Jul 13, 2015

I noticed with this change, that it puts the archives in the main product dir, just like on darwin, and freebsd, so no need to check in two places for the object files, which was a hack to begin with.

I think we're getting damn close to master here.

@cowboyd
enhance the binary builders by
0f96678 
* doing a full clone of the depot tools. I thought that I could save
  some time, but it means that building the binaries is not idempotent
* using rvm instead of system ruby
@cowboyd
Copy link
Collaborator Author

cowboyd commented Jul 13, 2015

So after the remaining 2 PR's is there any work left to do before merging to master?

@ignisf
Copy link
Collaborator

ignisf commented Jul 13, 2015

What I think would be nice is to package only the needed sources in the source distribution of the gem and not execute depot tools when it's installed. IIRC the patcher needed to be executed upon installation because there are environment-specific patches that need to be applied. The source however is the same for everybody.

This does not stop us from merging into master.

@ignisf
Copy link
Collaborator

ignisf commented Jul 13, 2015

Disregard that.. This would break using with gem ... github: ...

@cowboyd
Copy link
Collaborator Author

cowboyd commented Jul 13, 2015

Believe it or not, I actually tried that at first, but

  1. All the crap depot tools pooped into vendor/v8 was something like 125M
  2. the build lost its mind when it found that vendor/v8 was not a git repot.

cowboyd and others added 13 commits July 13, 2015 16:45
@cowboyd
Merge pull request #184 from cowboyd/container-based-travis
c3ad860 
use container based builds on travis
@cowboyd
Merge pull request #186 from cowboyd/update-binary-builds
054c56d 
enhance the binary builders
@ignisf
Add a 64-bit FreeBSD 10.1 build
0fa385d
@ignisf
Add amd64 to arch detection
10e62c8
@ignisf
Use NFS for Vagrant shared folders for FreeBSD
9d305e1
@ignisf
Confiure the host-only network adapter for FreeBSD
4152edf 
NFS requires a host-only network to be present.
@cowboyd
Merge pull request #190 from cowboyd/freebsd-vagrant-box
4504cdc 
FreeBSD Vagrant box
@ignisf
Install and use g++ 4.8 in Travis
6b57f9d
@ignisf
Add a Requirements section and update the README
bc7e50c
@ignisf
Remove stale patches for arm and Apple clang 5.1
1f540a2 
These patches were not getting applied anyway. If the arm patches are
still needed, they will be applied as necessary at a later stage.
@cowboyd
Merge pull request #191 from cowboyd/use-gcc48-in-travis
e4a6d63 
Install and use g++ 4.8 in Travis
@cowboyd
Merge pull request #192 from cowboyd/readme-update-for-4.5
92792f2 
Add a Requirements section and update the README
@cowboyd
Merge pull request #193 from cowboyd/remove-unnecessary-patches
0b97c04 
Remove stale patches for arm and Apple clang 5.1
@ignisf ignisf mentioned this pull request Oct 21, 2015
Closed
@mintrigue
Copy link

Is this upgrade dead?

@jarredholman
Copy link
Contributor

On the windows side of things, getting the build working is a nightmare.

@ignisf ignisf merged commit 0b97c04 into master May 13, 2016
@ignisf ignisf deleted the 4.5 branch May 13, 2016 20:28
@ignisf ignisf mentioned this pull request Jun 15, 2016
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cowboyd @ignisf @jarredholman @mintrigue @Robdel12