Skip to content
This repository was archived by the owner on Jul 31, 2023. It is now read-only.

Add tslint/prettier for linting/formatting. #299

Merged
merged 4 commits into from
Mar 31, 2018
Merged

Add tslint/prettier for linting/formatting. #299

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
30098a5
Add tslint/prettier extensions for linting/formatting.
gurgeous Mar 14, 2018
1da912f
don't need this stanza anymore
gurgeous Mar 14, 2018
a5d45fa
Switch to tslint-microsoft-contrib. Turned off a few rules that seem
gurgeous Mar 14, 2018
b0eb4e9
Merge branch 'master' into prettier_tslint
wingrunr21 Mar 31, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .prettierrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
{
"printWidth": 100,
"singleQuote": true,
"trailingComma": "es5",
"useTabs": true
}
3 changes: 3 additions & 0 deletions .vscode/extensions.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
{
"recommendations": ["esbenp.prettier-vscode", "eg2.tslint"]
}
8 changes: 7 additions & 1 deletion .vscode/settings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,11 @@
"files.trimTrailingWhitespace": true,
"eslint.enable": false,
"editor.insertSpaces": false,
"[javascript]": {
"editor.formatOnSave": true
},
"[typescript]": {
"editor.formatOnSave": true
},
"typescript.tsdk": "node_modules/typescript/lib"
}
}
169 changes: 167 additions & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

15 changes: 13 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,10 @@
"gulp-typescript": "^2.12.0",
"gulp-util": "^3.0.5",
"mocha": "^2.4.5",
"prettier": "^1.11.1",
"run-sequence": "*",
"tslint": "^5.9.1",
"tslint-config-prettier": "^1.10.0",
"typescript": "^2.1.5",
"vscode": "^1.1.4",
"vscode-debugadapter-testsupport": "^1.19.0"
Expand Down Expand Up @@ -135,13 +138,21 @@
},
"ruby.codeCompletion": {
"type": "string",
"enum": ["solargraph", "rcodetools", "none"],
"enum": [
"solargraph",
"rcodetools",
"none"
],
"default": "solargraph",
"description": "Method to use for code completion."
},
"ruby.intellisense": {
"type": "string",
"enum": ["solargraph", "rubyLocate", "none"],
"enum": [
"solargraph",
"rubyLocate",
"none"
],
"default": "solargraph",
"description": "Method to use for intellisense (go to definition, etc.)."
},
Expand Down
7 changes: 7 additions & 0 deletions tslint.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"defaultSeverity": "error",
"extends": ["tslint:recommended", "tslint-config-prettier"],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking tslint-microsoft-contrib vs tslint:recommended here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have zero experience with ts or tslint. Fine with me :)

"jsRules": {},
"rules": {},
"rulesDirectory": []
}