This repository was archived by the owner on Jul 31, 2023. It is now read-only.
Add support for custom ports to the Ruby debugger. #127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 11, 2017 16:20
This makes the code compile.
|
Can I have some help with getting the tests to pass @rebornix ? |
|
@ukblewis I'll take a look |
|
@rebornix Thank you - any progress so far? |
rebornix
reviewed
Apr 17, 2017
src/ruby.ts
Outdated
| @@ -218,7 +222,7 @@ export class RubyProcess extends EventEmitter { | |||
|
|
|||
| this.debugprocess.stderr.on('data', (data: Buffer) => { | |||
| if (/^Fast Debugger/.test(data.toString())) { | |||
| this.debugSocketClient.connect(1234); | |||
| this.debugSocketClient.connect(args.debuggerPort); | |||
There was a problem hiding this comment.
args.debuggerPort might be undefined so you may want to use args.debuggerPort | 1234, that's why the test cases fail.
rebornix
reviewed
Apr 17, 2017
.travis.yml
Outdated
| @@ -9,7 +9,7 @@ before_install: | |||
| - nvm install v5.10.0 | |||
| - nvm use v5.10.0 | |||
| before_script: | |||
| - npm install -g typescript | |||
| - npm install -g typescript@1.8.2 | |||
There was a problem hiding this comment.
I already fix this in master, do you mind reverting this line of change.
|
LGTM, just two tiny comments and they should be real easy fix. |
added 2 commits
April 20, 2017 00:42
|
@ukblewis thanks, it's really awesome! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure these boxes are checked before submitting your PR -- thanks in advance!