FIX: Memoize Singed.output_directory to prevent path override #42
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
After setting
Singed.output_directory = "flamegraphs/"inside development.rb the gem initialisation defaults it back to "tmp/speedscope"Solution
Added memoization using the
||=operator to cache the computed path after its first calculation. This ensures that:Impact
Testing
Resulting stacktrace from server after change with bundle open

Before hand:

development.rb setup
