retain code-range upon string extraction + align with strscan.c #186
+37
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kares
force-pushed
the
jruby-compat+cr-clean
branch
from
5634bbe to
d3202bd
Compare
kares
changed the title
kares
changed the title
kares
changed the title
headius
approved these changes
Jan 5, 2026
Contributor
|
Looks good, thank you! If you don't have any other changes coming we could spin a release. |
Contributor
Author
|
I don't have anything else atm, would be great to have a release. |
Contributor
|
Released in v3.1.7! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added an extra step upon creating a substring from
scanner.string-> retaining code-range when possiblealso, there was an attempt to raise
"regexp buffer overflow"uponMatcher.INTERRUPTED(-2), which isn't possible as theRubyRegexp#matcherMatch/matcherSearchhandle the interrupt return.a follow-up on #185