fix(bundler): only preload git sources for requested groups #9234
+54
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seuros
force-pushed
the
fix-git-preload
branch
from
3d0bb78 to
2d9586a
Compare
Member
|
Please describe detail of your issue and add test for that scenario. I'm not sure what is the problem. |
seuros
force-pushed
the
fix-git-preload
branch
2 times, most recently
from
4dbeb4c to
8b1b9eb
Compare
Author
|
When running Example scenario:
It only happens if i have a pretty large github repository with my tools and noticed that the docker image differed largely when bundled via bundler vs ore vs gel. |
Skip fetching git sources for excluded groups (--without). This is important for production builds where development git dependencies may be private repos without access, or should not be included in Docker images.
seuros
force-pushed
the
fix-git-preload
branch
from
8b1b9eb to
26de392
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found this bug that happens only if we have dev dependency pointing to git sources.