Move require_eof handling to C API
#2678
Open
+35
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
st0012
reviewed
Oct 9, 2025
src/parser.c
Outdated
| } | ||
| } | ||
|
|
||
| CHECK_PARSE(parser_pop_typevar_table(parser)); |
There was a problem hiding this comment.
Can you try moving this before the if condition above?
CHECK_PARSE(parser_pop_typevar_table(parser));
if (require_eof) {
rbs_parser_advance(parser);
if (parser->current_token.type != pEOF) {
rbs_parser_set_error(parser, parser->current_token, true, "expected a token `%s`", rbs_token_type_str(pEOF));
return false;
}
}
There was a problem hiding this comment.
This makes sure when we see pEOF, the typevar table is still popped.
There was a problem hiding this comment.
Hmm... Confirmed the typevar_table is allocated through the allocator. So, this should not actually cause a leak. 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
require_eof:argument inParser.parse_method_typeis handled by the Ruby extension layer, but this PR moves the feature to the C API, enabling other RBS parser clients, like Sorbet, to utilize it as well.