Support all rm_r options in Pathname#rmtree #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FileUtils#rmtree was an alias for #rm_rf. Perhaps this would make it even better to not support the force: true option, but to keep it "force: true" at all time, anyway?
matzbot
pushed a commit
to ruby/ruby
that referenced
this pull request
May 20, 2022
schneems
pushed a commit
to schneems/ruby
that referenced
this pull request
Jul 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a fuller set of options passed through to the FileUtils method being supported on Pathname. Fixes #6
Question
FileUtils#rmtreewas an alias forFileUtils#rm_rf.This PR moves from
rm_rtorm_rf, to reflect the API documentation notes.This is a change of the implementation.
Would you prefer to change the documentation OR the implementation?