Skip to content

Conversation

@headius
Copy link
Contributor

@headius headius commented Dec 9, 2022

Remove all shipped files and require path on JRuby until we can add JRuby's extension to the gem.

Temporary workaround for #48

Remove all shipped files and require path on JRuby until we can
add JRuby's extension to the gem.

Temporary workaround for ruby#48
@headius
Copy link
Contributor Author

headius commented Dec 9, 2022

Appears to work properly for me locally. We will try to get the real extension bits in here early in 2023.

[] date $ gem install date-3.3.0-java.gem 
Successfully installed date-3.3.0-java
Parsing documentation for date-3.3.0-java
Installing ri documentation for date-3.3.0-java
Done installing documentation for date after 0 seconds
1 gem installed
[] date $ jruby -e 'require "date"'
[] date $ jruby -e 'gem "date"; require "date"'

@headius headius mentioned this pull request Dec 9, 2022
@hsbt hsbt merged commit 4c8781c into ruby:master Dec 9, 2022
@hsbt
Copy link
Member

hsbt commented Dec 9, 2022

We try this by date-3.3.1

@dentarg
Copy link

dentarg commented Dec 13, 2022

@hsbt can you create a GitHub release (https://github.com/ruby/date/releases) for 3.3.1 so it matches https://rubygems.org/gems/date/versions?

@hsbt
Copy link
Member

hsbt commented Dec 13, 2022

done https://github.com/ruby/date/releases/tag/v3.3.1

@headius headius deleted the jruby_noop branch February 9, 2023 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants