Adding SNAP capability

[rmoreliovlabs]

Description

I have implemented the analysis documentation that explores various options for enabling SNAP feature discovery among connected peers. You can view the detailed analysis here: SNAP Feature Discovery Analysis

Motivation and Context

Establishing a decentralized approach for RSKj nodes to seamlessly discover and establish connections with SNAP-sync-provider peers during their initial connection phase. This enhancement will focus on integrating a new capability into the HelloMessage and HandshakeHandler classes, thereby facilitating efficient peer discovery and connectivity within the network

How Has This Been Tested?

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• Tests for the changes have been added (for bug fixes / features)
• Requires Activation Code (Hard Fork)

• Other information:

[asoto-iov]

As a summary I think that before approve we should discuss about:

• having a snap sync versioning.
• Review if it has sense to finish the handshake if the RSK protocol is not supported.

[Vovchyk]

now we would also need to filer snap-capable peers in here. And for that we'd need to extend Peer interface with new method - boolean isSnapCapable(), wdyt?

[asoto-iov]

it is still missing what Vlad mentioned here: #2628 (review)

[fmacleal]

Good job. I have a few comments, some improvements suggestion and also other related with tests. Let me know what you think. 🙂

[fmacleal]

LGTM

[asoto-iov]

Please review the new comment. I think it is needed to review the getBestSnapPeer candidate filtering to avoid unnecessary communication with non snap capable peers.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
78.8% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud