-
Notifications
You must be signed in to change notification settings - Fork 0
Add base class containing migrated pegin logic #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Dependency ReviewThe following issues were found:
|
Luisfc68
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a couple of extra comments:
- if you have a main file or something that you're using to test this it would be nice if you commit that file too for now, later we can remove it or convert it into a integration test file
- If I recall correctly, eslint doesn't check code format anymore in the latests versions, so if we could add prettier to the repo as well it would be very useful
Thanks for the review! I'll add a basic test case here since I'm currently testing from another project. We can definitely expand that to integration tests later. On formatting, I’m using ESLint with stylistic rules, but we can switch to Prettier if you think it's a better fit. |
Thank you! About the formatting, no need, I wasn't aware stylistic plugin, if we're addressing the code format with that is fine |
No description provided.