Skip to content

Conversation

@lserra-iov
Copy link
Contributor

No description provided.

@lserra-iov lserra-iov requested a review from Luisfc68 February 17, 2025 14:04
@github-actions
Copy link

github-actions bot commented Feb 17, 2025

Dependency Review

The following issues were found:

  • ✅ 0 vulnerable package(s)
  • ✅ 0 package(s) with incompatible licenses
  • ✅ 0 package(s) with invalid SPDX license definitions
  • ✅ 0 package(s) with unknown licenses.
  • ⚠️ 2 packages with OpenSSF Scorecard issues.

View full job summary

Copy link
Contributor

@Luisfc68 Luisfc68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a couple of extra comments:

  • if you have a main file or something that you're using to test this it would be nice if you commit that file too for now, later we can remove it or convert it into a integration test file
  • If I recall correctly, eslint doesn't check code format anymore in the latests versions, so if we could add prettier to the repo as well it would be very useful

@lserra-iov
Copy link
Contributor Author

a couple of extra comments:

  • if you have a main file or something that you're using to test this it would be nice if you commit that file too for now, later we can remove it or convert it into a integration test file
  • If I recall correctly, eslint doesn't check code format anymore in the latests versions, so if we could add prettier to the repo as well it would be very useful

Thanks for the review! I'll add a basic test case here since I'm currently testing from another project. We can definitely expand that to integration tests later. On formatting, I’m using ESLint with stylistic rules, but we can switch to Prettier if you think it's a better fit.

@Luisfc68
Copy link
Contributor

Luisfc68 commented Feb 21, 2025

Thanks for the review! I'll add a basic test case here since I'm currently testing from another project. We can definitely expand that to integration tests later. On formatting, I’m using ESLint with stylistic rules, but we can switch to Prettier if you think it's a better fit.

Thank you! About the formatting, no need, I wasn't aware stylistic plugin, if we're addressing the code format with that is fine

@lserra-iov lserra-iov merged commit 9f6efb0 into main Feb 21, 2025
3 checks passed
@lserra-iov lserra-iov deleted the base-pegin branch February 21, 2025 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants