Eliminate 'use autodie' from files touched by Perl core build process

Restore explicit checking for success of system calls as in version 5 of
podlators.

This is needed because podlators is bundled into the Perl core
distribution where it is handled in the build process at a point where
some of autodie's prerequisites are not yet built.

See discussion in #32 and
Perl/perl5#22395.

Co-authored-by: James E Keenan <[email protected]>

Author: rra

Makefile.PL

@@ -13,7 +13,6 @@
 # SPDX-License-Identifier: GPL-1.0-or-later OR Artistic-1.0-Perl
 
 use 5.012;
-use autodie;
 use warnings;
 
 use Config;
@@ -27,14 +26,14 @@ use File::Spec;
 # Returns: Distribution version as a string
 sub dist_version {
     my ($path) = @_;
-    open(my $fh, '<', $path);
+    open(my $fh, '<', $path) or die "$0: cannot open $path: $!\n";
     while (defined(my $line = <$fh>)) {
         if ($line =~ m{ \A package \s+ \S+ \s+ (v[\d.]+) }xms) {
-            close($fh);
+            close($fh) or die "$0: cannot close $path: $!\n";
             return $1;
         }
     }
-    close($fh);
+    close($fh) or die "$0: cannot close $path: $!\n";
     die "$0: cannot find version in lib/Pod/Man.pm\n";
 }
 

scripts/pod2man.PL

@@ -5,7 +5,6 @@
 # Perl core.
 
 use 5.012;
-use autodie;
 use warnings;
 
 use Config qw(%Config);
@@ -20,14 +19,14 @@ use File::Basename qw(basename dirname);
 
 # This forces PL files to create target in same directory as PL file.
 # This is so that make depend always knows where to find PL derivatives.
-chdir(dirname($0));
+chdir(dirname($0)) or die "Cannot change directories: $!\n";
 my $file = basename($0, '.PL');
 if ($^O eq 'VMS') {
     $file .= '.com';
 }
 
 # Create the generated script.
-open(my $out, '>', $file);
+open(my $out, '>', $file) or die "Cannot create $file: $!\n";
 print "Extracting $file (with variable substitutions)\n"
   or die "$0: cannot write to stdout: $!\n";
 
@@ -560,8 +559,8 @@ Perl core distribution as of 5.6.0.
 SCRIPT_BODY
 
 # Finish the generation of the script.
-close($out);
-chmod(0755, $file);
+close($out) or die "Cannot close $file: $!\n";
+chmod(0755, $file) or die "Cannot reset permissions for $file: $!\n";
 if ($Config{'eunicefix'} ne q{:}) {
     exec("$Config{'eunicefix'} $file");
 }