Skip to content

Porting/sync-with-cpan having trouble with version declared in package statement #22395

@jkeenan

Description

@jkeenan

Yesterday I received email notification of the release of podlators-v6.0.0. (It now uses semantic versioning.) Porting/core-cpan-diff confirmed this:

...
podlators:
    Perl: RRA/podlators-5.01.tar.gz
    CPAN: RRA/podlators-v6.0.0.tar.gz
...

I prepared to sync v6.0.0 into blead, which required me to first removed the CUSTOMIZED entry for cpan/podlators in Porting/sync-with-cpan. All went smoothly after that, but just at the point where I was ready to create a pull request, I decided to check the overall diff from my local branch to blead. I discovered, that Porting/sync-with-cpan apparently failed to pick up the declaration of versioning which now looks like this on CPAN:

$ ack '^package ' lib/
lib/Pod/Man.pm
15:package Pod::Man v6.0.0;

lib/Pod/Text/Termcap.pm
13:package Pod::Text::Termcap v6.0.0;

lib/Pod/Text/Overstrike.pm
20:package Pod::Text::Overstrike v6.0.0;

lib/Pod/Text/Color.pm
13:package Pod::Text::Color v6.0.0;

lib/Pod/ParseLink.pm
14:package Pod::ParseLink v6.0.0;

lib/Pod/Text.pm
15:package Pod::Text v6.0.0;

In my branch, I got diffs like this:

diff --git a/cpan/podlators/lib/Pod/Text.pm b/cpan/podlators/lib/Pod/Text.pm
index ef76bd9d03..83a7ce22a8 100644
--- a/cpan/podlators/lib/Pod/Text.pm
+++ b/cpan/podlators/lib/Pod/Text.pm
@@ -24,8 +24,7 @@ use Exporter ();
 use Pod::Simple ();
 
 our @ISA = qw(Pod::Simple Exporter);
-our $VERSION = '5.01_02';
-$VERSION =~ tr/_//d;
+our $VERSION = '5.01';
 

Further inspection showed that none of the real code changes from v6.0.0 were picked up. (See: https://github.com/jkeenan/perl5/tree/podlators-sync-20241011.)

I haven't yet inspected Porting/sync-with-cpan to see whether the problem comes from the (new) absence of $VERSION in the lib/Pod/*.pm files or from the semantic versioning in the package declaration -- or the combination of the two. In any event, my belief is that Porting/sync-with-cpan needs some repairs. (I'll hold off on attempting a sync of podlators-v6.0.0 into blead pending discussion.)

Metadata

Metadata

Assignees

No one assigned

    Labels

    InfrastructureThings needed to maintain Perl development

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions