Skip to content

Conversation

jannic
Copy link
Member

@jannic jannic commented Oct 22, 2023

According to cargo semver-checks, that's necessary to stay semver compatible with v0.9.0

According to cargo semver-checks, that's necessary to stay semver compatible with v0.9.0
@jannic jannic force-pushed the v0.9-semver-compat branch from e7717ec to 0e0506c Compare October 22, 2023 21:28
@jannic jannic added this to the 0.9.1 milestone Oct 22, 2023
@jannic jannic added the non-breaking change This pull requests contains a minor, not SemVer breaking, change label Oct 22, 2023
Copy link
Member

@9names 9names left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
Do we have a release planning doc to ensure this change is reverted before the next minor release?

@jannic
Copy link
Member Author

jannic commented Nov 10, 2023

Do we have a release planning doc to ensure this change is reverted before the next minor release?

No, but I'll post a new merge-request with the revert, and tag it with the 0.10.0 milestone.

@jannic jannic merged commit 0046f4d into rp-rs:main Nov 10, 2023
@jannic jannic deleted the v0.9-semver-compat branch November 10, 2023 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
non-breaking change This pull requests contains a minor, not SemVer breaking, change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants