Remove the requirement for multicore tasks to never return #594
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ithinuel
force-pushed
the
do-not-require-multicore-callback-to-never-return
branch
from
bb47c10 to
b277b1e
Compare
|
This is a breaking change, as proven by the failing doc test, https://github.com/rp-rs/rp-hal/actions/runs/4880039111/jobs/8707219403?pr=594 In the end, it's a tradeoff. Pro:
Cons:
Any arguments I missed? |
ithinuel
force-pushed
the
do-not-require-multicore-callback-to-never-return
branch
from
0ff44c4 to
a3a18bb
Compare
jannic
reviewed
May 7, 2023
jannic
added
the
breaking change
jannic
reviewed
May 20, 2023
jannic
approved these changes
May 20, 2023
Co-authored-by: Jan Niehusmann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative solution to #592