Fix renamed rcpputils header
#198
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Abrar Rahman Protyasha <[email protected]>
Member
Author
|
The Rpr job fails as expected because the renamed header is not in a release yet. CI from ros2/rcpputils#150: Repos file: https://gist.github.com/aprotyas/96874af9175859555af0144398e0bf25
CI (again) from ros2/rcpputils#150 following ros2/rcpputils@18b406b. Repos file: https://gist.github.com/aprotyas/96874af9175859555af0144398e0bf25
|
3 tasks
clalancette
requested changes
Nov 2, 2021
fujitatomoya
approved these changes
Nov 2, 2021
clalancette
approved these changes
Nov 3, 2021
Member
Author
|
Two approvals and CI is green, so I'll merge this in. Thanks for the reviews! |
delete-merged-branch
bot
deleted the
aprotyas/rcpputils_fix_env_header
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rcpputils/get_env.hppis renamed torcpputils/env.hppas part of ros2/rcpputils#150, so the corresponding includes have been fixed in this PR.Signed-off-by: Abrar Rahman Protyasha [email protected]