Add RMW_DURATION_INFINITE basic compliance test #194
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Emerson Knapp <[email protected]>
clalancette
approved these changes
Jul 21, 2021
Contributor
clalancette
left a comment
clalancette
left a comment
There was a problem hiding this comment.
Seems reasonable to me with green CI. Though it might be good to have @jacobperron review before merging.
Contributor
Author
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to ros2/rmw#301 - adding a compliance test so that RMW implementations are guaranteed to handle these values properly.
Tests pass locally against all default checked-out RMW implementations:
rmw_fastrtpsrmw_cycloneddsrmw_connextrmw_connextddsFor context, ros2/rosbag2#756 was an uncaught case of this being a problem. It led to ros2/rmw_connextdds#43, where @jacobperron recommended I create this test.
For a failing case, I reverted ros2/rmw_connextdds#43 in a branch, and rant this test against that version to see a failure.