Test SubscriptionOptions::ignore_local_publications #192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jose Antonio Moral <[email protected]>
hidmic
reviewed
Jun 2, 2021
fujitatomoya
reviewed
Jun 3, 2021
Collaborator
fujitatomoya
left a comment
fujitatomoya
left a comment
There was a problem hiding this comment.
lgtm with @hidmic comments.
Signed-off-by: Jose Antonio Moral <[email protected]>
Signed-off-by: Jose Antonio Moral <[email protected]>
hidmic
reviewed
Jun 7, 2021
Signed-off-by: Jose Antonio Moral <[email protected]>
Signed-off-by: Jose Antonio Moral <[email protected]>
Contributor
Author
To my understanding, this should happen after a manual trigger, right? Otherwise, there is no way to test it with the changes introduced at ros2/rmw_fastrtps#536 |
Contributor
|
CI up to
|
Contributor
|
Let's try again, CI up to
|
Contributor
|
To pass the Rolling PR job (and merge this), we need ros2/rmw_fastrtps#536 released. @MiguelCompany do you want to hold that until ros2/rmw_fastrtps#540 gets in? |
Contributor
|
Alright, ros/rosdistro#30076 is up. Once it's in, we can re-run the PR job and merge if everything's still fine. |
Contributor
|
@ros-pull-request-builder retest this please |
Contributor
|
Alright, all green! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jose Antonio Moral [email protected]
Related to ros2/rmw_fastrtps#536