Deprecate method names that use CamelCase in rclcpp_components #1716
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rebecca Butler <[email protected]>
Member
|
We might want to deprecated the old signatures (except the new create_node_options), to make the transition softer for anyone relying on this API. @wjwwood What do you think? |
Contributor
Author
|
build:
|
Member
👍 deprecate in humble and remove in i-turtle. |
Signed-off-by: Rebecca Butler <[email protected]>
rebecca-butler
changed the title
jacobperron
approved these changes
Jul 16, 2021
Contributor
Author
|
Triggering CI again:
|
87 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a follow-up to #1702, this PR renames the methods to use snake_case so they will be consistent with the other ROS 2 core packages.
Signed-off-by: Rebecca Butler [email protected]