Fix deprecated subscriber callback warnings #323
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These fixes target the following packages within examples: * `examples_rclcpp_cbg_executor` * `multithreaded_executor` * `minimal_subscriber` * `minimal_publisher` Signed-off-by: Abrar Rahman Protyasha <[email protected]>
Member
Author
|
Full CI:
|
jhdcs
approved these changes
Aug 20, 2021
Contributor
jhdcs
left a comment
jhdcs
left a comment
There was a problem hiding this comment.
Looks like a straightforward change to me.
Member
Author
|
Yellow CI for Windows is unrelated to this package - originates from |
wjwwood
approved these changes
Aug 21, 2021
fujitatomoya
approved these changes
Aug 23, 2021
delete-merged-branch
bot
deleted the
aprotyas/deprecate-shared-ptr-sub-callback
branch
87 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ros2/rclcpp#1713 deprecates the
void shared_ptr<T>subscription callback signatures, so this PR migrates away from said signatures.These fixes target the following packages within examples:
examples_rclcpp_cbg_executormultithreaded_executorminimal_subscriberminimal_publisherSigned-off-by: Abrar Rahman Protyasha [email protected]