Skip to content

Conversation

@xmfcx
Copy link
Contributor

@xmfcx xmfcx commented Dec 1, 2021

This feature adds a geometry_msgs::msg::Polygon field to the shape_msgs/msg/SolidPrimitive.msg in order to represent PRISM primitive too.

Explained in detail in #166

@xmfcx xmfcx force-pushed the add-prism-to-solid-primitive branch from 78ffd64 to c631ba4 Compare December 1, 2021 17:51
Copy link
Member

@gbiggs gbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xmfcx
Copy link
Contributor Author

xmfcx commented Dec 8, 2021

@clalancette is it ok to merge this into master?

@gbiggs gbiggs merged commit 90a4602 into ros2:master Dec 8, 2021
xmfcx added a commit to xmfcx/common_interfaces that referenced this pull request Dec 9, 2021
xmfcx added a commit to xmfcx/common_interfaces that referenced this pull request Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants