Skip to content

Conversation

@ktgilliam
Copy link
Contributor

…ING.md

Please add the following dependencies to the rosdep database.

Package name:

astrometry

Package Upstream Source:

Purpose of using this:

Used by downstream packages that perform astrometric plate solving and image-based WCS solutions. This rosdep rule allows those ROS packages and CI to install the dependency via pip on platforms where no native distro package exists.

Distro packaging links:

  • Debian: not available (pip-only)
  • Ubuntu: not available (pip-only)
  • Fedora: not available (pip-only)
  • Arch: not available (pip-only)
  • Gentoo: not available (pip-only)
  • macOS (homebrew): not available (pip-only)
  • Alpine: not available (pip-only)

Package name:

photutils

Package Upstream Source:

Purpose of using this:

Provides photometry tools used by downstream image-processing code to detect and measure sources in astronomical images. Adding this rosdep rule ensures the Python dependency can be installed in CI and on developer machines where a distro package is not available.

Distro packaging links:

  • Debian: not available (pip-only)
  • Ubuntu: not available (pip-only)
  • Fedora: not available (pip-only)
  • Arch: not available (pip-only)
  • Gentoo: not available (pip-only)
  • macOS (homebrew): not available (pip-only)
  • Alpine: not available (pip-only)

Distro packaging notes

  • Both packages are pip-only on common distributions at time of writing. The proposed rosdep entries add pip fallbacks for Debian/Ubuntu/Fedora per repository conventions.
  • If native distro packages become available later, distro-specific mappings can be added and the pip fallback adjusted/removed.

Testing performed

  • Updated local rosdep (used local rosdep/python.yaml for testing):
    • ROSDEP_YAML="$(pwd)/rosdep/python.yaml" rosdep resolve python3-astrometry-pip --os=ubuntu:22.04
    • ROSDEP_YAML="$(pwd)/rosdep/python.yaml" rosdep resolve python3-photutils-pip --os=debian:bookworm
    • ROSDEP_YAML="$(pwd)/rosdep/python.yaml" rosdep resolve photutils --os=ubuntu:22.04
  • Repository formatting checks:
    • pytest -q test/rosdep_formatting_test.py::test — PASS

License information

  • Please verify upstream license metadata:
    • astrometry: check PyPI page (GNU GENERAL PUBLIC LICENSE Version 3, 29 June 2007 at time of this PR)
    • photutils: check PyPI page (BSD-3-Clause license at time of this PR)

Checks

  • All packages have a declared license in the package.xml (N/A — these are pip-only rosdep rules)
  • This repository has a LICENSE file
  • This package is expected to build on the submitted rosdistro (validated via rosdep resolve + formatting test and pip install checks)

Notes for reviewers

  • If maintainers prefer a different EOL date or anchor placement, I can update the change.

@ktgilliam ktgilliam requested a review from a team as a code owner October 22, 2025 03:35
@github-actions github-actions bot added the rosdep Issue/PR is for a rosdep key label Oct 22, 2025
github-actions[bot]

This comment was marked as outdated.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For changes related to rosdep:

  • ✅ New rosdep keys are named appropriately
  • ✅ Platforms for new rosdep rules are valid
  • ✅ Installers for new rosdep rules are valid
  • ✅ New keys appear suitable for rosdep

For changes related to yamllint:

  • ✅ All new lines of YAML pass linter checks

@mjcarroll mjcarroll added the rosdep-needs-second-approval rosdep key PR is waiting for a 2nd approval label Oct 25, 2025
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For changes related to rosdep:

  • ✅ New rosdep keys are named appropriately
  • ✅ Platforms for new rosdep rules are valid
  • ✅ Installers for new rosdep rules are valid
  • ✅ New keys appear suitable for rosdep

For changes related to yamllint:

  • ✅ All new lines of YAML pass linter checks

@christophebedard
Copy link
Member

@Mergifyio rebase

@mergify
Copy link

mergify bot commented Oct 29, 2025

rebase

✅ Branch has been successfully rebased

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For changes related to rosdep:

  • ✅ New rosdep keys are named appropriately
  • ✅ Platforms for new rosdep rules are valid
  • ✅ Installers for new rosdep rules are valid
  • ✅ New keys appear suitable for rosdep

For changes related to yamllint:

  • ✅ All new lines of YAML pass linter checks

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For changes related to rosdep:

  • ✅ New rosdep keys are named appropriately
  • ✅ Platforms for new rosdep rules are valid
  • ✅ Installers for new rosdep rules are valid
  • ✅ New keys appear suitable for rosdep

For changes related to yamllint:

  • ✅ All new lines of YAML pass linter checks

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For changes related to rosdep:

  • ✅ New rosdep keys are named appropriately
  • ✅ Platforms for new rosdep rules are valid
  • ✅ Installers for new rosdep rules are valid
  • ✅ New keys appear suitable for rosdep

For changes related to yamllint:

  • ✅ All new lines of YAML pass linter checks

Comment on lines 2864 to 2866
debian: [python-pexpect]
gentoo: [dev-python/pexpect]
ubuntu: [python-pexpect]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is complaining about this, which is most likely valid, but we don't really want it to complain about entries that were not modified in this PR.

We could just force-merge this, but I don't have the permissions for that. @cottsay did you want to force-merge this?

@mjcarroll
Copy link
Member

CC: @cottsay I'm going to force-merge this at end-of-day

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For changes related to rosdep:

  • ✅ New rosdep keys are named appropriately
  • ✅ Platforms for new rosdep rules are valid
  • ✅ Installers for new rosdep rules are valid
  • ✅ New keys appear suitable for rosdep

For changes related to yamllint:

  • ✅ All new lines of YAML pass linter checks

Copy link
Member

@cottsay cottsay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not really sure where the line change identification code is going wrong here, but this code is overdue for migration to rosdistro-reviewer so I'm not going to take the time to root-cause the issue here.

@cottsay cottsay merged commit 5c57076 into ros:master Nov 3, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rosdep Issue/PR is for a rosdep key rosdep-needs-second-approval rosdep key PR is waiting for a 2nd approval

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants