-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Add entries for astrometry and photutils #48286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For changes related to rosdep:
- ✅ New rosdep keys are named appropriately
- ✅ Platforms for new rosdep rules are valid
- ✅ Installers for new rosdep rules are valid
- ✅ New keys appear suitable for rosdep
For changes related to yamllint:
- ✅ All new lines of YAML pass linter checks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For changes related to rosdep:
- ✅ New rosdep keys are named appropriately
- ✅ Platforms for new rosdep rules are valid
- ✅ Installers for new rosdep rules are valid
- ✅ New keys appear suitable for rosdep
For changes related to yamllint:
- ✅ All new lines of YAML pass linter checks
|
@Mergifyio rebase |
✅ Branch has been successfully rebased |
fc058be to
14dc5d2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For changes related to rosdep:
- ✅ New rosdep keys are named appropriately
- ✅ Platforms for new rosdep rules are valid
- ✅ Installers for new rosdep rules are valid
- ✅ New keys appear suitable for rosdep
For changes related to yamllint:
- ✅ All new lines of YAML pass linter checks
14dc5d2 to
d6b46a4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For changes related to rosdep:
- ✅ New rosdep keys are named appropriately
- ✅ Platforms for new rosdep rules are valid
- ✅ Installers for new rosdep rules are valid
- ✅ New keys appear suitable for rosdep
For changes related to yamllint:
- ✅ All new lines of YAML pass linter checks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For changes related to rosdep:
- ✅ New rosdep keys are named appropriately
- ✅ Platforms for new rosdep rules are valid
- ✅ Installers for new rosdep rules are valid
- ✅ New keys appear suitable for rosdep
For changes related to yamllint:
- ✅ All new lines of YAML pass linter checks
| debian: [python-pexpect] | ||
| gentoo: [dev-python/pexpect] | ||
| ubuntu: [python-pexpect] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI is complaining about this, which is most likely valid, but we don't really want it to complain about entries that were not modified in this PR.
We could just force-merge this, but I don't have the permissions for that. @cottsay did you want to force-merge this?
|
CC: @cottsay I'm going to force-merge this at end-of-day |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For changes related to rosdep:
- ✅ New rosdep keys are named appropriately
- ✅ Platforms for new rosdep rules are valid
- ✅ Installers for new rosdep rules are valid
- ✅ New keys appear suitable for rosdep
For changes related to yamllint:
- ✅ All new lines of YAML pass linter checks
cottsay
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not really sure where the line change identification code is going wrong here, but this code is overdue for migration to rosdistro-reviewer so I'm not going to take the time to root-cause the issue here.
…ING.md
Please add the following dependencies to the rosdep database.
Package name:
astrometry
Package Upstream Source:
Purpose of using this:
Used by downstream packages that perform astrometric plate solving and image-based WCS solutions. This rosdep rule allows those ROS packages and CI to install the dependency via pip on platforms where no native distro package exists.
Distro packaging links:
Package name:
photutils
Package Upstream Source:
Purpose of using this:
Provides photometry tools used by downstream image-processing code to detect and measure sources in astronomical images. Adding this rosdep rule ensures the Python dependency can be installed in CI and on developer machines where a distro package is not available.
Distro packaging links:
Distro packaging notes
Testing performed
License information
Checks
Notes for reviewers