Make flutter_map v8 possible #86
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Thank you @enricostrijks, I've chosen to accept this PR in favour of the other two as it seems to contain the least amount of unnecessary formatting changes. Would you be interested in being a maintainer? I'm not using this project anymore and I don't have time to dedicate to it. I know the pain of waiting on a new version for ages so it would be nice to have someone else who can help with that. |
JekaNS
reviewed
Apr 27, 2025
| ), | ||
| )) continue; | ||
| if (!map.pixelBounds.contains(Offset(width, height))) { | ||
| continue; |
There was a problem hiding this comment.
Marker always out of bounds ((
After calculation in rows 74,75 width always equals m.width and height always equals m.height
That corresponds just size of marker, but not a position
Fix here PR#88
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.