Skip to content

Conversation

jeroen
Copy link
Member

@jeroen jeroen commented Nov 5, 2024

@maelle
Copy link
Member

maelle commented Nov 12, 2024

One comment: the new font looks thicker.

@jeroen
Copy link
Member Author

jeroen commented Nov 12, 2024

I think we ended up making the css bolder in many places to make proxima-nova more readable, if we switch we probably need to undo that.

@maelle
Copy link
Member

maelle commented Apr 4, 2025

@jeroen I looked at this again, intending to change font-weight but... it does not seem that thick to me today?! I think the PR looks fine.

@steffilazerte
Copy link
Member

If I were to really stare at them and be picky, I think I have a slight preference for our original font, but they look pretty similar, and I like the idea of using open fonts (seems to fit our mission). But the font size looks bigger on this PR than on the regular page, and I don't like that as much.

@maelle
Copy link
Member

maelle commented Apr 10, 2025

make font less big?

@maelle
Copy link
Member

maelle commented May 12, 2025

I'll open a new PR.

@maelle
Copy link
Member

maelle commented May 12, 2025

The problem is that in the SCSS files, we've set the font size many times (178 occurrences in 22 files).

I think looking at the different values of font sizes (there are not 178 of them) would take a little while.

For instance with the native font stack at 17px this looks ok:

image

Compared to Proxima nova at 18px:

image

Do things really look bad when just changing the font without changing the size?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Switch to native font stack

3 participants