Raise the number of new possible tags

[LeoColomb]

And make sure they have to be created.
Closes roots/wordpress#44

A little bit "wtf" I'm afraid.

[LeoColomb]

Up to 50 new versions in a batch (hopefully enough)

[LeoColomb]

An array of already-existing-tags-on-meta-package requests is run to ensure correctness of the workflow

[LeoColomb]

When the request is 404, the tag does not exist and ready to be created

[LeoColomb]

Retrieve the tag from the request.
Definitely ugly.

[swalkinshaw]

🤔 what about using the tag we already have above? We just need to wrap that promise above somehow?

This might work:

const targetTags = await Promise.allSettled(
  upstreamTags
    .filter((tag) => !currrentTags.find((t) => t.name === tag.name))
    .map((tag) =>
      github.rest.git.getRef({
        owner: context.repo.owner,
        repo: META.substring(META.indexOf('/') + 1),
        ref: 'tags/' + tag.name,
      }).then(res => ({ tag: tag, res }))
    )
)
return targetTags
  .filter(({res}) => res.reason.status === 404) // Non existent tags
  .map({tag} => tag.name)

[LeoColomb]

That's smart, not that obvious though:

• The then is not sufficient as we need to cover the failure as well (actually the failure is the value here)
• Promise.allSettled has a weird behavior to always wrap the results into .value

const targetTags = await Promise.allSettled(
  upstreamTags
    .filter((tag) => !currrentTags.find((t) => t.name === tag.name))
    .map((tag) =>
      github.rest.git
        .getRef({
          owner: context.repo.owner,
          repo: META.substring(META.indexOf('/') + 1),
          ref: 'tags/' + tag.name,
        })
        .then(() => {})
        .catch((res) => ({ tag: tag.name, status: res.status }))
    )
)
return targetTags
  .filter(({ value }) => value?.status === 404)
  .map(({ value }) => value.tag)

PR updated

[LeoColomb]

But that's still a bit wtf 😁

[swalkinshaw]

From my brief check, octokit never rejects a promise. It's always fulfilled as a success just with an error message in it. Did you see otherwise?

[LeoColomb]

Octokit rejects promises if fetch/xhr is failing, but inside a Promise.allSettled with then/catch it makes it wrapped into another always fulfilled promise.