Add support for boolean values in open office files that were generat… #580
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed via Google Sheets
|
@kakubin can you prioritize this PR as well? |
kakubin
approved these changes
Feb 7, 2023
CHANGELOG.md
Outdated
Comment on lines
2
to
3
| - Fix gsub! usage for open office documents on a frozen string [580](https://github.com/roo-rb/roo/pull/580) | ||
| - Add support for boolean values in open office files that were generated via Google Sheets [579](https://github.com/roo-rb/roo/pull/579) |
There was a problem hiding this comment.
This new line should be end with link #580
There was a problem hiding this comment.
Let me fix this up. Must have been mixed up in the merge
There was a problem hiding this comment.
@kakubin Have another look now - the other line in the changelog was wrong as well. Both were using the issues numbers and not the PR numbers.
kakubin
approved these changes
Feb 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
###Description
Resolves #579
@kakubin here is my first fix. Please have a look - happy for feedback.