Rely on user names for projection table in extraction. #21191
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous code was probably buggy, because the corresponding inductive table uses user names, so there might have been a desynchronization. That said, it is not even clear because the data is the same for aliased inductive types, and was not even accessed by the code. So this change should be a no-op. To make this clearer, we seize the opportunity to replace maps with sets.
ppedrot
added
kind: cleanup
coqbot-app
bot
removed
the
request: full CI
SkySkimmer
approved these changes
Oct 11, 2025
|
@coqbot merge now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous code was probably buggy, because the corresponding inductive table uses user names, so there might have been a desynchronization. That said, it is not even clear because the data is the same for aliased inductive types, and was not even accessed by the code. So this change should be a no-op. To make this clearer, we seize the opportunity to replace maps with sets.