Deprecate some set / map structures based on canonical names in Names. #21189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is not complete but at least it signals to all downstream users, including Rocq code itself, that these modules should not be used.
ppedrot
added
kind: cleanup
coqbot-app
bot
removed
the
request: full CI
SkySkimmer
approved these changes
Oct 11, 2025
ppedrot
added
the
needs: overlay
ppedrot
added a commit
to ppedrot/coq-tactician
that referenced
this pull request
Oct 11, 2025
We use sets based on user names rather than canonical names. This may result in different behaviour in presence of module aliasing, but it is not clear to me from my weak understanding of the code alone that this is actually not the desired behaviour. The new code is backwards compatible in terms of API.
ppedrot
added a commit
to ppedrot/coq-lsp
that referenced
this pull request
Oct 11, 2025
This should be backwards compatible and actually fixes a type piercing mismatch that happens to be correct by accident.
SkySkimmer
added a commit
to ejgallego/rocq-lsp
that referenced
this pull request
Oct 13, 2025
LasseBlaauwbroek
added a commit
to coq-tactician/coq-tactician
that referenced
this pull request
Oct 13, 2025
SkySkimmer
removed
the
needs: overlay
|
@coqbot merge now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not complete but at least it signals to all downstream users, including Rocq code itself, that these modules should not be used.
Backwards compatible overlays: