-
Notifications
You must be signed in to change notification settings - Fork 697
Nix: cleanup, refactor, modernize #21093
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Thanks for the initial heads up. This thing is indeed outdated. Currently, the most used Nix machinery around Rocq is the toolbox: https://github.com/rocq-community/coq-nix-toolbox/ that is used both to test nixpkgs PRs and in multiple CIs. |
|
There are many, currently under-maintained, pieces of Nix infra in this repo. The one that I introduced and that I continue to use for development (but recently failed to update, see #20441) is the Lines 402 to 443 in 30e9382
Then, there is the infrastructure added by @vbgl under https://github.com/rocq-prover/rocq/tree/master/dev/ci/nix for reverse dependencies. I don't know if this infra is still used by anyone. These two parts could be (rather easily) superseded by using the Coq Nix Toolbox as is, and I think it should be done. There was an initial attempt by myself to do this a long time ago in #14435, but I think it was too ambitious (we shouldn't test reverse dependencies in the Nix CI setup for now). Then, there is the flake part that this PR attempts to update. This was introduced without consideration for existing Nix infra in #17675, to be reused in the VsCoq repo. I was always very reluctant to this duplication and the way this was done. Now, this could also be superseded by the Coq Nix Toolbox if we finished the PR that Pierre linked above. That being said, I don't see this happening in the foreseeable future. I personally don't intend to work on this for a while. |
I think this part can be safely removed. |
|
Also note the related #19298, which I should have re-reviewed, but didn't so far. |
Hey everyone!
I saw that the rocq Nix infra seems not to be maintained very actively, so I thought I'd give it a proper cleaning and fix some outdated stuff. This is still very WIP, but I thought I'd push it as a Draft prematurely to get some feedback, as I am not that familiar with rocq.
If this is unwelcome, please do tell me so as this PR is likely to be a bigger (~500-600loc) one; It would be good to know before I spend some hours on this.