Skip to content

Conversation

Zimmi48
Copy link
Member

@Zimmi48 Zimmi48 commented Jul 23, 2025

Fix #16956.
Fix #20717.

This longs CSS selector comes from what I found in my web browser inspector. I didn't try to make sense of it or whether it could be simplified. I just tested that it fixed the issue.

@cpitclaudel Is putting this piece of CSS in notations.css OK?

@Zimmi48 Zimmi48 added this to the 9.0.1 milestone Jul 23, 2025
@Zimmi48 Zimmi48 requested a review from a team as a code owner July 23, 2025 15:02
@Zimmi48 Zimmi48 added kind: fix This fixes a bug or incorrect documentation. kind: documentation Additions or improvement to documentation. labels Jul 23, 2025
@coqbot-app coqbot-app bot added the needs: full CI The latest GitLab pipeline that ran was a light CI. Say "@coqbot run full ci" to get a full CI. label Jul 23, 2025
@jfehrle
Copy link
Member

jfehrle commented Jul 24, 2025

Looks good for #20717

@cpitclaudel
Copy link
Contributor

Seems fine to place it in notations.css. But perhaps the following is enough?

.rst-content dl:not(.docutils) dt {
    padding: 6px;
    display: table;
}

We could also just pin the old theme.

@Zimmi48
Copy link
Member Author

Zimmi48 commented Aug 4, 2025

Thanks, I confirmed that your solution works as well and pushed it instead of mine.

@Zimmi48
Copy link
Member Author

Zimmi48 commented Aug 6, 2025

This is ready to merge, and if someone (e.g., @proux01) could merge this PR (or any other one), this would trigger a new Docker build for the dev images.

Copy link
Contributor

@proux01 proux01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trusting everyone here

@proux01 proux01 self-assigned this Aug 6, 2025
@proux01 proux01 removed the needs: full CI The latest GitLab pipeline that ran was a light CI. Say "@coqbot run full ci" to get a full CI. label Aug 6, 2025
@proux01
Copy link
Contributor

proux01 commented Aug 6, 2025

@coqbot merge now

@coqbot-app coqbot-app bot merged commit aa1e044 into rocq-prover:master Aug 6, 2025
6 checks passed
SkySkimmer added a commit that referenced this pull request Sep 5, 2025
ppedrot added a commit to ppedrot/coq that referenced this pull request Sep 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: documentation Additions or improvement to documentation. kind: fix This fixes a bug or incorrect documentation.
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

Excessive HTML highlighting for lists in documentation Display issue with Sphinx 5.1.1
4 participants