Cleanup handling of projection flags #20605
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Subflags like coercion locality are only present when the projection
is to be declared as a projection.
Get rid of `check_priorities` as something like
~~~coq
Class x0 (n:nat) := {}.
Record foo := { x1 : nat; baz :: x0 x1 | 3 }.
~~~
does not need to error.
SkySkimmer
added
kind: cleanup
coqbot-app
bot
added
the
needs: full CI
SkySkimmer
added a commit
to SkySkimmer/coq-elpi
that referenced
this pull request
May 6, 2025
SkySkimmer
added
the
request: full CI
coqbot-app
bot
removed
request: full CI
SkySkimmer
added
the
needs: overlay
SkySkimmer
added a commit
to SkySkimmer/MetaRocq
that referenced
this pull request
May 6, 2025
SkySkimmer
added a commit
to SkySkimmer/rocq-lean-import
that referenced
this pull request
May 6, 2025
SkySkimmer
added a commit
to SkySkimmer/coq-lsp
that referenced
this pull request
May 6, 2025
SkySkimmer
added
request: full CI
SkySkimmer
force-pushed
the
simpl-proj-flags
branch
from
8cf16c9 to
d93f460
Compare
coqbot-app
bot
removed
the
request: full CI
ejgallego
added a commit
to ejgallego/rocq-lsp
that referenced
this pull request
May 6, 2025
Adapt to rocq-prover/rocq#20605 (cleaned up projection flags)
ppedrot
approved these changes
May 13, 2025
|
@coqbot merge now |
This comment was marked as resolved.
This comment was marked as resolved.
ppedrot
added a commit
to MetaRocq/metarocq
that referenced
this pull request
May 15, 2025
Adapt to rocq-prover/rocq#20605 (cleaned up projection flags)
ppedrot
added a commit
to LPCIC/coq-elpi
that referenced
this pull request
May 15, 2025
Adapt to rocq-prover/rocq#20605 (cleanup record field flags)
SkySkimmer
added a commit
to rocq-community/rocq-lean-import
that referenced
this pull request
May 15, 2025
Adapt to rocq-prover/rocq#20605 (cleaned up projection flags)
|
stdlib CI for metarocq is failing with the error introduced in this commit https://github.com/rocq-prover/stdlib/actions/runs/15085835936/job/42408257533?pr=144#step:11:3672 |
|
The error is correct |
|
In what sense is the error correct? Are you saying it was always there, or should have been? I am asking because this is a kind:cleanup kind:internal PR without a changelog, so having a non-plugin build that passed before fail now is not automatically expected. |
|
It should have been |
|
Makes sense. When you get a chance, could you please write changelog / porting guidance and point the metarocq maintainers to it. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overlays: