Explicitly pass the safe env to Namegen.next_global_ident_away. #20423
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppedrot
added
kind: cleanup
coqbot-app
bot
removed
the
request: full CI
SkySkimmer
added
the
needs: overlay
This function was the only one in namegen to directly access the global environment. Given that there are not that many callers and they are all in the upper layers, we pass the environment used to check for freshness functionally.
ppedrot
added a commit
to ppedrot/Coq-Equations
that referenced
this pull request
Mar 31, 2025
ppedrot
added a commit
to ppedrot/rocq-lean-import
that referenced
this pull request
Mar 31, 2025
ppedrot
added a commit
to ppedrot/rewriter
that referenced
this pull request
Mar 31, 2025
ppedrot
added
the
request: full CI
ppedrot
force-pushed
the
namegen-no-global
branch
from
ff29481 to
c5f258d
Compare
coqbot-app
bot
removed
the
request: full CI
ppedrot
removed
the
needs: overlay
SkySkimmer
approved these changes
Apr 1, 2025
|
@coqbot merge now |
|
@SkySkimmer: Please take care of the following overlays:
|
SkySkimmer
added a commit
to rocq-community/rocq-lean-import
that referenced
this pull request
Apr 1, 2025
ppedrot
added a commit
to mattam82/Coq-Equations
that referenced
this pull request
Apr 1, 2025
JasonGross
pushed a commit
to ppedrot/rewriter
that referenced
this pull request
Apr 3, 2025
ppedrot
added a commit
to ppedrot/rewriter
that referenced
this pull request
Apr 3, 2025
JasonGross
pushed a commit
to mit-plv/rewriter
that referenced
this pull request
Apr 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function was the only one in namegen to directly access the global environment. Given that there are not that many callers and they are all in the upper layers, we pass the environment used to check for freshness functionally.
Overlays: